Adding the track building for the muon trigger in the new JO test (ATR-20388):
- cloned the offline flags to set muon trigger specific values, and added the track builder as part of the muon trigger reco sequence
- migrated the tools in the muon seeded segment finder to be private
- removed a few instances of 'addPublicTool' where we can use private tools
- note that the region selector service used by the segment recovery is currently the default (which is correct at the moment), but this will probably need to be changed in the future, so keeping the property commented out for now.

Making a few tools that were public to be private, and started to update the configuration to use private tools in a few place.

Configure MuonTrackSummaryHelperTool where it's needed.

Robert Johannes Langenberg authored 5 years ago and Edward Moyse committed 5 years ago

create Tracking/TrkConfig package, move all new configuration files in, update path where they were used

Make some common functions in MuonConfigUtils, to synchronise the various top level tests in the package.

Edward Moyse authored 5 years ago and Walter Lampl committed 5 years ago

Make more muon tools private, and move to the new gaudi property declaration. Add some more configuration to MooCandidateMatchingTool, now that tools are private.

Updated `ComponentAccumulator` configuration tests which dump the configuration
to a pickle file. In python3 the output file needs to be explicitly opened in binary mode.
I.e. ```f = open('configdump.pkl','wb')```
rather than ```f = open('configdump.pkl','w')```

Not complete yet, but after using comparePickledConfig.py there are a few real issues fixed, and some changes to make comparison easier.
- use useAlignmentCorrections on by default
- some missing configuration of tools e.g. CalibCscStripFitterCfg, MuonPhiHitSelector, MuPatHitToolCfg
- some names changed to match old configuration
- private tool configuration added to MooTrackFitterCfg

This new argument is off by default, because actually for initial tests it's okay if we cannot clone muon algorithms. So let's make the standard tests a bit easier.
Also code cleanup:
- changed message formatting to show slot/event
- moved this into the args.run check (since for pickling it doesn't work)

Added missing configuration for MuPatCandidateTool for MooCandidateMatchingTool, and made it private (and new Gaudi property declaration)

Update the input ESD file for the unit tests to Zmumu. Keep the old default commented out for the moment, in case we want to revert.

Edward Moyse authored 5 years ago and Walter Lampl committed 5 years ago

The code is still there but commented, because it can be useful for debugging.

Currently the algorithms are not clonable (which is correct, since they are not MT compliant) but we need to make them so for testing. So I've added some configuration to override this.

Fixes for missing configuration for TGCs in some places, and handle the fact that TGC ELs are broken in some files (ATLASRECTS-5151)

Cleaned up TrackEventCnvTool (making the sub-tools private, for example).
Added a new ability to MuonEventCnvTool to fix ATLASRECTS-5151 (and configured this on in the two main reco sub-steps in MuonConfig).
Made MuonEventCnvTool a friend of TGC ROT (not strictly necessary, but cleaner)

Edward Moyse authored 5 years ago and Walter Lampl committed 5 years ago

Ongoing effort to get Muon standalone working. Now added ability to set arguments, to be used in ART tests. Found some missing configuration which is now added. And a protection against a rare crash.

Fixes for configutation of MooSegmentCombinationFinder to allow it to be overridden properly for NCB
Added missing MuonChamberHoleRecoveryToolCfg for track building
General fixes to make the concurrency configurable at runtime
Added some args to allow new threaded tests to work
Whitespace fixes, and also a protection against crashing for ATLASRECTS-5087 (real fix still under investigation).

- Removed deprecated config flag
- Moved common tool configuration into new MuonRecToolsConfig.py (and removed this from MuonSegmentFindingConfig.py)
- Added a lot of new configuration to MuonTrackBuildingConfig.py
- Added TrackBuilding to MuonReconstructionConfig.py

William Axel Leight authored 5 years ago and Frank Winklmeier committed 5 years ago

The service now uses the MdtCondDbData object created by the MdtCondDbAlg, rather than the MdtCondSummarySvc.
The MdtIntersectGeometry objects are no longer cached in the service but created on the fly as needed, making the service much simpler.
Mutable data members are removed or made local variables.
The MdtCondDbData object and the MuonDetectorManager must now be passed in from outside: the clients of the service are adjusted accordingly.
The MdtCondDbAlg must now run during muon reconstruction: the configuration is updated accordingly.

Edward Moyse authored 5 years ago and Frank Winklmeier committed 5 years ago

- Removed deprecated config flag
- Moved common tool configuration into new MuonRecToolsConfig.py (and removed this from MuonSegmentFindingConfig.py)
- Added a lot of new configuration to MuonTrackBuildingConfig.py
- Added TrackBuilding to MuonReconstructionConfig.py