AtlasTest/DatabaseTest/AthenaPoolTest/src/AthenaPoolTestDataReader.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 /**
@@ -180,7 +180,7 @@ StatusCode AthenaPoolTestDataReader::execute()
     //bool readMatrix = false;
     bool readMatrix = true;
     if (readMatrix) {
-        const AthenaPoolTestMatrix* matrix;
+        const AthenaPoolTestMatrix* matrix = nullptr;
         for ( int i = 0; i < 3; ++i ) {
             std::stringstream stream;
             stream << "AthenaPoolTestMatrix_" << i;

AtlasTest/DatabaseTest/IOVDbTestAlg/src/IOVDbTestAlg.cxx

 /*
-  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "IOVDbTestAlg.h"
@@ -394,7 +394,7 @@ StatusCode IOVDbTestAlg::printCondObjects() const {
     ATH_MSG_INFO( "in printCondObjects()" );
 
     // IOVDbTestMDTEleMap
-    const IOVDbTestMDTEleMap* elemMap;
+    const IOVDbTestMDTEleMap* elemMap = nullptr;
     ATH_CHECK( detStore()->retrieve(elemMap, "/IOVDbTest/IOVDbTestMDTEleMap") );
     ATH_MSG_INFO( "Retrieved IOVDbTestMDTEleMap " );
     

Calorimeter/CaloLumiConditions/CMakeLists.txt

-# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 
 # Declare the package name:
 atlas_subdir( CaloLumiConditions )
@@ -12,6 +12,12 @@ atlas_add_library( CaloLumiConditions
                    PUBLIC_HEADERS CaloLumiConditions
                    LINK_LIBRARIES CxxUtils Identifier AthenaKernel LArElecCalib
                    PRIVATE_LINK_LIBRARIES LArIdentifier LumiBlockData )
+if( CMAKE_COMPILER_IS_GNUCXX )
+  # When we compile with -flto, we get bogus warnings about ODR violations
+  # from the multiversioned function CaloBCIDCoeffs::calc().
+  # Just suppress the warnings for now.
+  set_target_properties( CaloLumiConditions PROPERTIES COMPILE_FLAGS "-Wno-odr -Wno-lto-type-mismatch" LINK_FLAGS "-Wno-odr -Wno-lto-type-mismatch" )
+endif()
 
 atlas_add_test( CaloBCIDCoeffs_test
                 SOURCES

Calorimeter/CaloRec/src/CaloBCIDCoeffsCondAlg.cxx

 /*
- * Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration.
+ * Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration.
  */
 /**
  * @file CaloRec/src/CaloBCIDCoeffsCondAlg.cxx
@@ -34,12 +34,12 @@ StatusCode CaloBCIDCoeffsCondAlg::initialize()
 
   
   if ( m_isSC ) {
-	const LArOnline_SuperCellID* ll;
+	const LArOnline_SuperCellID* ll = nullptr;
 	ATH_CHECK(detStore()->retrieve(ll,"LArOnline_SuperCellID"));
 	m_laronline_id = (const LArOnlineID_Base*)ll;
   }
   else {
-	const LArOnlineID* ll;
+	const LArOnlineID* ll = nullptr;
 	ATH_CHECK(detStore()->retrieve(ll,"LArOnlineID"));
 	m_laronline_id = (const LArOnlineID_Base*)ll;
   }

Calorimeter/CaloTrackUtils/src/CaloClusterVertexFractionMaker.cxx

@@ -139,7 +139,7 @@ CaloClusterVertexFractionMaker::execute(const EventContext& ctx,
                 *m_discSurface_atCaloEntrance_positiveZ,
                 Trk::alongMomentum,
                 true,
-                Trk::pion));
+                Trk::pion).release());
           } else if (theTrackParticle->eta() <
                      -1.35) // track most likely in endcap C, extrapolate track
                             // to a disc at ID exist in negative z direction
@@ -151,7 +151,7 @@ CaloClusterVertexFractionMaker::execute(const EventContext& ctx,
                 *m_discSurface_atCaloEntrance_negativeZ,
                 Trk::alongMomentum,
                 true,
-                Trk::pion));
+                Trk::pion).release());
           } else // track is in barrel, extrapolate to cylinder at ID exit
           {
             trackParameters_atCaloEntrance =
@@ -161,7 +161,7 @@ CaloClusterVertexFractionMaker::execute(const EventContext& ctx,
                                             *m_cylinderSurface_atCaloEntrance,
                                             Trk::alongMomentum,
                                             true,
-                                            Trk::pion));
+                                            Trk::pion).release());
           }
           if (trackParameters_atCaloEntrance != nullptr) {
             m_trkParticleEta_atCaloEntrance->push_back(trackParameters_atCaloEntrance->position().eta());

Calorimeter/CaloTriggerTool/src/LArTTCellMap.cxx

 /*
-  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "CaloTriggerTool/LArTTCellMap.h"
@@ -36,10 +36,10 @@ void LArTTCellMap::set( const LArTTCell& m )
 
   ServiceHandle<StoreGateSvc> detStore ("DetectorStore", "LArTTCellMap");
 
-  const LArEM_ID* em_id;
-  const LArHEC_ID* hec_id;
-  const LArFCAL_ID* fcal_id;
-  const CaloLVL1_ID* lvl1_id;
+  const LArEM_ID* em_id = nullptr;
+  const LArHEC_ID* hec_id = nullptr;
+  const LArFCAL_ID* fcal_id = nullptr;
+  const CaloLVL1_ID* lvl1_id = nullptr;
 
   StatusCode status=detStore->retrieve(em_id);
   if(status.isFailure()){

Control/AthenaConfiguration/python/AtlasSemantics.py

-# Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 
 import GaudiConfig2.semantics
 from GaudiKernel.GaudiHandles import PrivateToolHandleArray, PublicToolHandle, ServiceHandle
@@ -218,19 +218,3 @@ GaudiConfig2.semantics.SEMANTICS.append(PublicHandleSemantics)
 GaudiConfig2.semantics.SEMANTICS.append(PublicHandleArraySemantics)
 GaudiConfig2.semantics.SEMANTICS.append(SubAlgoSemantics)
 GaudiConfig2.semantics.SEMANTICS.append(MapMergeNoReplaceSemantics)
-
-
-#For some obscure reason, _ListHelper object never compare equal. Therefore PropertySemantics merge() method fails
-def _sequencemerge(instance,a,b):
-    if a.data != b.data:
-        raise ValueError('cannot merge sequence of values %r and %r' % (a, b))
-    else:
-        return a
-    
-from GaudiConfig2.semantics import SequenceSemantics
-SequenceSemantics.merge = _sequencemerge
-del _sequencemerge
-
-
-
-

Control/AthenaIPCTools/src/AthenaSharedMemoryTool.cxx

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 /* file contains the implementation for the AthenaSharedMemoryTool class.
@@ -17,6 +17,7 @@
 
 const std::size_t maxTokenLength = 512;
 
+namespace {
 struct ShareEventHeader {
    enum ProcessStatus { CLEARED, FILLED, LOCKED, UNLOCKED, PARTIAL, SHARED, UNKNOWN };
    ProcessStatus evtProcessStatus;
@@ -28,6 +29,7 @@ struct ShareEventHeader {
    unsigned int evtCoreStatusFlag;
    char token[maxTokenLength];
 };
+} // anonymous namespace
 
 //___________________________________________________________________________
 AthenaSharedMemoryTool::AthenaSharedMemoryTool(const std::string& type,

Control/AthenaIPCTools/src/AthenaYamplTool.cxx

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "AthenaYamplTool.h"
@@ -12,6 +12,7 @@
 #include "yampl/SocketFactory.h"
 #include <sstream>
 
+namespace {
 struct ShareEventHeader {
    long evtSeqNumber;
    long fileSeqNumber;
@@ -21,6 +22,7 @@ struct ShareEventHeader {
    uint32_t evtTerm1;
    uint32_t evtTerm2;
 };
+} // anonymous namespace
 
 //___________________________________________________________________________
 AthenaYamplTool::AthenaYamplTool(const std::string& type,

Control/AthenaServices/ATLAS_CHECK_THREAD_SAFETY

+Control/AthenaServices

Control/AthenaServices/src/AthDictLoaderSvc.h

 ///////////////////////// -*- C++ -*- /////////////////////////////
 
 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 // AthDictLoaderSvc.h 
@@ -32,7 +32,7 @@ class ITPCnvSvc;
 class ISvcLocator;
 template <class TYPE> class SvcFactory;
 
-class ATLAS_CHECK_THREAD_SAFETY AthDictLoaderSvc
+class AthDictLoaderSvc
   : virtual public ::IDictLoaderSvc,
             public ::AthService
 { 

Control/AthenaServices/src/AthenaEventLoopMgr.cxx

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #define  GAUDISVC_EVENTLOOPMGR_CPP
 
+#include "CxxUtils/checker_macros.h"
+ATLAS_NO_CHECK_FILE_THREAD_SAFETY;  // non-MT EventLoopMgr
+
 #include <cassert>
 #include <ios>
 #include <iostream>

Control/AthenaServices/src/AthenaEventLoopMgr.h

 // -*- C++ -*-
 
 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef ATHENASERVICES_ATHENAEVENTLOOPMGR_H
@@ -11,6 +11,9 @@
 
 */
 
+#include "CxxUtils/checker_macros.h"
+ATLAS_NO_CHECK_FILE_THREAD_SAFETY;  // non-MT EventLoopMgr
+
 #include <string>
 #include <vector>
 #include "GaudiKernel/IEvtSelector.h"

Control/AthenaServices/src/AthenaMtesEventLoopMgr.cxx

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "AthenaMtesEventLoopMgr.h"
@@ -699,7 +699,9 @@ StatusCode AthenaMtesEventLoopMgr::nextEvent(int maxevt)
 
   yampl::ISocketFactory* socketFactory = new yampl::SocketFactory();
   // Create a socket to communicate with the Pilot
-  m_socket = socketFactory->createClientSocket(yampl::Channel(m_eventRangeChannel.value(),yampl::LOCAL),yampl::MOVE_DATA);
+  m_socket = socketFactory->createClientSocket(yampl::Channel(m_eventRangeChannel.value(),yampl::LOCAL),
+                                               yampl::MOVE_DATA, yampl::defaultDeallocator,
+                                               m_socketName.value());
 
   // Reset the application return code.
   resetAppReturnCode();
@@ -1347,12 +1349,12 @@ StatusCode AthenaMtesEventLoopMgr::clearWBSlot(int evtSlot)  {
 
 std::unique_ptr<AthenaMtesEventLoopMgr::RangeStruct> AthenaMtesEventLoopMgr::getNextRange(yampl::ISocket* socket)
 {
-  std::string strReady("Ready for events");
-  std::string strStopProcessing("No more events");
+  static const std::string strReady("Ready for events");
+  static const std::string strStopProcessing("No more events");
 
   std::string range;
   if( m_inTestMode ) {
-     static size_t line_n = 0;
+     static std::atomic<size_t> line_n = 0;
      info() <<"in TEST MODE, Range #" << line_n+1 << endmsg;
      range = (line_n < m_testPilotMessages.value().size()) ? m_testPilotMessages.value()[line_n++] : strStopProcessing;
   } else {
@@ -1361,7 +1363,7 @@ std::unique_ptr<AthenaMtesEventLoopMgr::RangeStruct> AthenaMtesEventLoopMgr::get
      memcpy(ready_message,strReady.data(),strReady.size());
      socket->send(ready_message,strReady.size());
      void* eventRangeMessage;
-     ssize_t eventRangeSize = socket->recv(eventRangeMessage);
+     ssize_t eventRangeSize = socket->recv(eventRangeMessage, m_socketName.value());
      range = std::string((const char*)eventRangeMessage,eventRangeSize);
      size_t carRet = range.find('\n');
      if(carRet!=std::string::npos) range = range.substr(0,carRet);

Control/AthenaServices/src/AthenaMtesEventLoopMgr.h

 // -*- C++ -*-
 
 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef ATHENASERVICES_ATHENAMTESEVENTLOOPMGR_H
@@ -291,6 +291,8 @@ private:
       , "The name of the Yampl channel between AthenaMT and the Pilot"
       };
 
+  Gaudi::Property<std::string> m_socketName{this, "SocketName", {}, "YAMPL socket name"};
+
   // Hopefully a temporary measurement. For the time being we cannot
   // support event ranges from different input files.
   std::string m_pfn{""};

Control/AthenaServices/src/AthenaSummarySvc.h

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef ATHENASERVICES_ATHENASUMSVC_H
@@ -32,7 +32,7 @@
 #include <fstream>
 
 
-class ATLAS_CHECK_THREAD_SAFETY AthenaSummarySvc :
+class AthenaSummarySvc :
   public extends<AthService, IIncidentListener, IAthenaSummarySvc> {
 
 public:

Control/AthenaServices/src/ConditionsCleanerSvc.h

 // This file's extension implies that it's C, but it's really -*- C++ -*-.
 /*
-  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 /*
  */
@@ -32,7 +32,7 @@ namespace Athena {
  * the concrete class in one place.  The concrete service may be left
  * unspecified, in which case no garbage collection will be done.
  */
-class ATLAS_CHECK_THREAD_SAFETY ConditionsCleanerSvc
+class ConditionsCleanerSvc
   : public extends<AthService, IConditionsCleanerSvc>
 {
 public:

Control/AthenaServices/src/CoreDumpSvc.cxx

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 /**
@@ -53,7 +53,7 @@
 
 namespace {
 
-  const char* horizLine = "-------------------------------------------------------------------------------------\n";
+  const char* const horizLine = "-------------------------------------------------------------------------------------\n";
 
    void ExitOnInt( int sig, siginfo_t*, void* ) {
       if ( sig == SIGINT ) {
@@ -85,12 +85,12 @@ namespace CoreDumpSvcHandler
   CoreDumpSvc* coreDumpSvc(nullptr);  ///< pointer to CoreDumpSvc
   std::ostream* ostr(&std::cout);     ///< stream for printing
 
-  std::ostream& log() { return *ostr; }  ///< convenience method for logging
+  std::ostream& log ATLAS_NOT_THREAD_SAFE () { return *ostr; }  ///< convenience method for logging
 
   /**
    * Signal handler for the CoreDumpSvc
    */
-  void action( int sig, siginfo_t *info, void* extra )
+  void action ATLAS_NOT_THREAD_SAFE ( int sig, siginfo_t *info, void* extra )
   {
     // Careful: don't do anything here that might allocate memory.
 
@@ -214,7 +214,7 @@ namespace CoreDumpSvcHandler
 //================================================================================
 // C'tor, D'tor, Property handler
 //================================================================================
-CoreDumpSvc::CoreDumpSvc( const std::string& name, ISvcLocator* pSvcLocator ) : 
+CoreDumpSvc::CoreDumpSvc( const std::string& name, ISvcLocator* pSvcLocator ) :
   base_class( name, pSvcLocator )
 {
   // Set us as the current instance
@@ -354,7 +354,7 @@ void CoreDumpSvc::setCoreDumpInfo( const EventContext& ctx, const std::string& n
 //----------------------------------------------------------------------
 // Print all core dump records
 //----------------------------------------------------------------------
-void CoreDumpSvc::print()
+void CoreDumpSvc::print ATLAS_NOT_THREAD_SAFE ()
 {
   ATH_MSG_FATAL("Caught fatal signal. Printing details to " << m_coreDumpStream.value() << ".");
   CoreDumpSvcHandler::log() << dump() << std::flush;
@@ -366,11 +366,12 @@ void CoreDumpSvc::print()
 std::string CoreDumpSvc::dump() const
 {
   std::ostringstream os;
+  char buf[26];
   const time_t now = time(nullptr);
   
   os << "-------------------------------------------------------------------------------------" << "\n";
   os << "Core dump from " << name() << " on " << System::hostName()
-     << " at " << ctime(&now) /*<< "\n"*/; // ctime adds "\n"
+     << " at " << ctime_r(&now, buf) /*<< "\n"*/; // ctime adds "\n"
   os << "\n";
 
   // Print additional information if available
@@ -556,7 +557,7 @@ void CoreDumpSvc::handle(const Incident& incident)
 //----------------------------------------------------------------------
 // Install signal handler
 //----------------------------------------------------------------------
-StatusCode CoreDumpSvc::installSignalHandler()
+StatusCode CoreDumpSvc::installSignalHandler ATLAS_NOT_THREAD_SAFE ()
 {
   ATH_MSG_DEBUG ("Installing signal handler");
   std::ostringstream oss;
@@ -594,7 +595,7 @@ StatusCode CoreDumpSvc::installSignalHandler()
 //----------------------------------------------------------------------
 // Uninstall signal handler
 //----------------------------------------------------------------------
-StatusCode CoreDumpSvc::uninstallSignalHandler()
+StatusCode CoreDumpSvc::uninstallSignalHandler ATLAS_NOT_THREAD_SAFE ()
 {
   ATH_MSG_DEBUG ("Uninstalling signal handler");
 

Control/AthenaServices/src/CoreDumpSvc.h

 /*
-  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef ATHENASERVICES_COREDUMPSVC_H
@@ -16,6 +16,7 @@
 
 // FrameWork includes
 #include "AthenaBaseComps/AthService.h"
+#include "CxxUtils/checker_macros.h"
 #include "GaudiKernel/IIncidentListener.h"
 #include "EventInfo/EventID.h"
 
@@ -24,7 +25,7 @@
 template <class TYPE> class SvcFactory;
 
 namespace CoreDumpSvcHandler {
-  void action( int sig, siginfo_t *info, void* extra );
+  void action ATLAS_NOT_THREAD_SAFE ( int sig, siginfo_t *info, void* extra );
 }
 
 /**
@@ -57,32 +58,32 @@ protected:
 public: 
 
   /// Constructor with parameters
-  CoreDumpSvc( const std::string& name, ISvcLocator* pSvcLocator );
+  CoreDumpSvc( const std::string& name, ISvcLocator* pSvcLocator ) ATLAS_CTORDTOR_NOT_THREAD_SAFE;
   
   /// Destructor
-  virtual ~CoreDumpSvc(); 
+  virtual ~CoreDumpSvc() ATLAS_CTORDTOR_NOT_THREAD_SAFE;
   
   /// \name ICoreDumpSvc implementation
   //@{  
   /// Set a name/value pair in the core dump record
-  virtual void setCoreDumpInfo( const std::string& name, const std::string& value );
+  virtual void setCoreDumpInfo( const std::string& name, const std::string& value ) override;
 
   /// Set a name/value pair in the core dump record for given EventContext
-  virtual void setCoreDumpInfo( const EventContext& ctx, const std::string& name, const std::string& value );
+  virtual void setCoreDumpInfo( const EventContext& ctx, const std::string& name, const std::string& value ) override;
 
   /// Print all core dump records
-  virtual std::string dump() const;
+  virtual std::string dump() const override;
   //@}
 
 
   /// \name Gaudi implementation
   //@{
-  virtual StatusCode initialize();
-  virtual StatusCode start();
-  virtual StatusCode finalize();
+  virtual StatusCode initialize ATLAS_NOT_THREAD_SAFE () override;
+  virtual StatusCode start() override;
+  virtual StatusCode finalize ATLAS_NOT_THREAD_SAFE () override;
   
   /// Incident listener
-  virtual void handle( const Incident& incident );
+  virtual void handle( const Incident& incident ) override;
   //@}
 
     
@@ -130,19 +131,19 @@ private:
   ///@}
 
   /// Property handler
-  void propertyHandler(Gaudi::Details::PropertyBase& p);
+  void propertyHandler ATLAS_NOT_THREAD_SAFE (Gaudi::Details::PropertyBase& p);
 
   /// Print core dump records to configured stream
-  void print();
+  void print ATLAS_NOT_THREAD_SAFE ();
   
   /// Set pointer to siginfo_t struct
   void setSigInfo(siginfo_t* info) { m_siginfo = info; }  
   
   /// Install signal handlers
-  StatusCode installSignalHandler();
+  StatusCode installSignalHandler ATLAS_NOT_THREAD_SAFE ();
   
   /// Uninstall signal handlers
-  StatusCode uninstallSignalHandler();
+  StatusCode uninstallSignalHandler ATLAS_NOT_THREAD_SAFE ();
 
   /// Set up an alternate stack for the current thread.
   void setAltStack();

Control/AthenaServices/src/DecisionSvc.h

 /*
-  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
 */
 #ifndef ATHENASERVICES_DECISIONSVC_H
 #define ATHENASERVICES_DECISIONSVC_H 
@@ -27,7 +27,7 @@
  * @author S.Binet<binet@cern.ch>
  * @author B.Radics<radbal@cern.ch>
  */
-class ATLAS_CHECK_THREAD_SAFETY DecisionSvc : public extends<AthService, IDecisionSvc>
+class DecisionSvc : public extends<AthService, IDecisionSvc>
 { 
 
 public: