manual sweep into master of 16464 from athenaprivate1 (!20011) · Merge requests · atlas / athena · GitLab

Miha Muskinja requested to merge mmuskinj/athena:master-Addition-StepHistograms into master Dec 18, 2018

This is a manual sweep of https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/16464#note_2176697 from the old repo into master.

The base class of StepHistogramTool needed to be migrated to UserActionToolBase from ActionToolBaseReport. This had some consequences, namely:

StepHistogramTool.h has now much less lines of code
results are accumulated in a different way: https://gitlab.cern.ch/atlas/athena/blob/91ab1c0d7b87e1cae72df085639ee5b1c94592b9/Simulation/G4Utilities/G4DebuggingTools/src/StepHistogramTool.cxx#L58 compared to previously used mergeReports();
preInclude does not longer specify ['Step']: https://gitlab.cern.ch/atlas/athena/blob/91ab1c0d7b87e1cae72df085639ee5b1c94592b9/Simulation/G4Utilities/G4DebuggingTools/share/preInclude.StepHistogram.py#L11 like in the 21.0 code: simFlags.OptionalUserActionList.addAction('G4UA::StepHistogramTool', ['Step'])