Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 132
    • Merge requests 132
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !20045

AthContainersInterfaces,etc: Change getSelectedAuxIDs to return by value.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Scott Snyder requested to merge ssnyder/athena:selected.AthContainersInterfaces-20181219 into master Dec 19, 2018
  • Overview 2
  • Commits 6
  • Pipelines 1
  • Changes 16

getSelectedAuxIDs() was returning a value by const reference, which was problematic for thread-safety, since that requires saving a copy of the set in the AuxSelector object. Change to returning by value. Now that auxid_set_t is represented by a bitmap with a move operator, that should not be very expensive.

Also change AuxDiscoverySvc::getauxIDs() to return by value.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: selected.AthContainersInterfaces-20181219