Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !20171

Use chain dicts to configure calo hypo tool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tomasz Bold requested to merge tbold/athena:use-chain-dicts-to-configure-calo-hypo-tool into master Jan 04, 2019
  • Overview 19
  • Commits 3
  • Pipelines 1
  • Changes 5

With this MR a transition is started so that hypo tools configuration uses the chain dict (from menu) rather than the chain name parsing. The previous method is left in place so that all the tests work. We will phase *FromName functions in one step once we are able to configure all hypos from chain dicts. The change should be approved by @bernius and ack. by @jmontejo and @aranzazu from menu group. I also made the congigurations unit testable, i.e. hopefully no silly python typo should sneak in.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: use-chain-dicts-to-configure-calo-hypo-tool