Integrate ID with New JO

The ID data prep works now withing New JO menu. The test has not been very thorough yet. It is clear the CA generator should be improved. One way would be not to fill eventAlgs list but that would make offline generators a bit cumbersome. Ideal addition would to have CA merge operation taking care of moving algorithms to a sequence. Another MR. The cache making algorithms would seem to be better separated from the reconstruction algorithms in future.

added 4 commits

• 48f075c0 - assured that input is matched to output even if some inputs are skipped, do not…
• 7ea2fa39 - added ID to electron chain, ref. changes because now the last step uses fake…
• 0cd8bfac - improved collection of hypos
• ee503584 - More informative messages

Compare with previous version

unmarked as a Work In Progress

changed title from WIP Attempt to integrate ID with New JO to Integrate ID with New JO

changed the description

This merge request affects 4 packages:

• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

added Trigger TriggerMenu master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20173-2019-01-10-23-53
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32116] (for remote access see the FAQ for MR reviewers)

Does anyone understand the issue with the tests in this MR? Looks like they were not started at all?

Hi Tomasz,

Two separate issues, which didn't get parsed properly by NICOS.

1)timeouts (Frontier access?) meant that the build timed out after one hour:

      Start 1257: TriggerJobOpts_TriggerConfigFlagsTest_ctest
23/31 Test #1257: TriggerJobOpts_TriggerConfigFlagsTest_ctest ......   Passed    3.09 sec
      Start 1258: TriggerJobOpts_TriggerMenuFlagsTest_ctest
24/31 Test #1258: TriggerJobOpts_TriggerMenuFlagsTest_ctest ........   Passed    1.42 sec
      Start 1259: TriggerJobOpts_TriggerConfigTest_ctest
25/31 Test #1259: TriggerJobOpts_TriggerConfigTest_ctest ...........   Passed    2.71 sec
      Start 1260: TriggerJobOpts_flake8_ctest
26/31 Test #1260: TriggerJobOpts_flake8_ctest ......................   Passed    5.55 sec
      Start 1264: TriggerMenuMT_generateMenuMT_newJO_ctest
27/31 Test #1264: TriggerMenuMT_generateMenuMT_newJO_ctest .........   Passed   34.87 sec
      Start 1265: TriggerMenuMT_generateMenuMT_ctest
Build timed out (after 60 minutes). Marking the build as failed.
Build was aborted
Finished: FAILURE

2)The newJOtest failed:

Traceback (most recent call last):
  File "newJOtest.py", line 56, in <module>
    acc.merge( TrigInDetCondConfig( flags ) )
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-slc6-gcc62-opt/python/TrigUpgradeTest/InDetConfig.py", line 56, in TrigInDetCondConfig
    acc.merge(InDetGMConfig(flags))
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-slc6-gcc62-opt/python/TrigUpgradeTest/InDetConfig.py", line 25, in InDetGMConfig
    geoModelSvc.DetectorTools['PixelDetectorTool'].BCM_Tool = bcmTool
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-slc6-gcc62-opt/python/AthenaCommon/PropertyProxy.py", line 252, in __set__
    value = self.convertValueToBeSet( obj, value )
  File "/build2/ci-builds/master/Athena/build/Athena/x86_64-slc6-gcc62-opt/python/AthenaCommon/PropertyProxy.py", line 344, in convertValueToBeSet
    (value.getJobOptName(),suggestion) )
RuntimeError: GeoModelSvc.PixelDetectorTool.BCM_Tool: Public tool InDetDD::BCM_Builder is not yet in ToolSvc. You may need to add jobOptions lines something like:
from AthenaCommon.AppMgr import ToolSvc
ToolSvc += InDetDD__BCM_Builder()
Exception RuntimeError: RuntimeError('ComponentAccumulator was not merged!',) in <bound method ComponentAccumulator.__del__ of <AthenaConfiguration.ComponentAccumulator.ComponentAccumulator object at 0x7fa8d2979450>> ignored
Exception RuntimeError: RuntimeError('ComponentAccumulator was not merged!',) in <bound method ComponentAccumulator.__del__ of <AthenaConfiguration.ComponentAccumulator.ComponentAccumulator object at 0x7fa8daf2d0d0>> ignored
ERROR in configuration generation stage, stopping

Cheers,

Stewart

So, would restart help?

The failure in newJO looks like a real bug - I guess you don't see that locally?

Cheers,

Stewart

added 1 commit

• e16566a1 - use addPublicTool instead of ToolSvc

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

Thanks @smh, The issue was in use of ToolSvc in ID example. Fixed it. Wonder why in r09 it worked. Bah, o.k. important is that we move forward here.

Ah, I clearly introduced that as a copy-paste error. Indeed, puzzling that it worked.

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20173-2019-01-11-16-21
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32142] (for remote access see the FAQ for MR reviewers)

Jenkins please retry a build

This merge request affects 4 packages:

• Trigger/TrigSteer/DecisionHandling
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20173-2019-01-15-07-47
Athena: number of compilation errors 1, warnings 3
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32223] (for remote access see the FAQ for MR reviewers)