Skip to content
Snippets Groups Projects

JetCalibTool scripts to produce paper figures

Merged Jonathan Bossio requested to merge jbossios/athena:21.2-JetCalibTools-Scripts into 21.2

News:

  • New script to plot eta correction as a function absolute detector eta
  • Small modification to script to plot jet energy response as a function of detector eta. It is possible now to only fill the distribution when the jet is above 20 GeV (if requested).

Those scripts can be used to produce the inputs to prepare the paper figures.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I made one comment, but didn't look at the MR as a whole, so the shifters should still check it in detail.

  • @jbossios, can you please implement the suggested changes for memory (using std::cout is OK), and address Nils' comment?

    Karolos (L2)

  • Technically we do have the AsgTools/MessageCheck.hh utility to allow using atlas messaging for the programs in the util directory, but so far that is only a recommendation, not a requirement.

  • Hi @jbossios, could you please add ATLAS Robot as developer to your new fork (https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot).

    Thanks, Tadej (L1)

  • Thanks! I forgot about it. It's done.

  • Hi @jbossios,

    Once this is updated to use smart pointers this can be merged in, but you should check with the relevant expert if he can update AccessorWrapper when he has a slow afternoon. There is really no point in copy-pasting this utility over a number of scripts. However, I don't want to hold up this MR for that, particularly since we already have a number of other scripts using it.

    Cheers, Nils

  • Hi,

    Maybe @delsart could take care of this, I believe he wrote JetFourMomAccessor in the first place. If not, maybe @mdaneri can, since she is responsible for JetCalibTools.

    Best, Jona

  • Hi All,

    Sorry I don't see the discussion/request about AccessorWraper in this MR ? Am I just blind or is it somewhere else ?

    Cheers, P-A

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading