Migrate SCT_DigitizationTool to use IAtRNGSvc for AthenaMT

In order to make the output of MT MC Overlay (and digitization) reproducible then we need to use the thread-safe random number service (via IAtRNGSvc) in all digitization code. This merge request does this for the SCT Digitization code. The approach taken is to retrieve the CLHEP::HepRandomEngine instance re-seeded for the current event in a method of the PileUpTool which is called once per event, this is then as an argument in calls to other methods where random numbers are required. This helps to make those tools (more) const.

Due to the slightly different way that the random number seeding is done in the MT service, the output is slightly different, but this should just be statistical.

added 1 commit

• caa08dfd - Migrate SCT_DigitizationTool to use IAtRNGSvc for AthenaMT

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• InnerDetector/InDetDigitization/SCT_Digitization
• InnerDetector/InDetDigitization/SiDigitization

Adding @jchapman ,@oda as watchers

added InnerDetector label

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20291-2019-01-14-18-49
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32209] (for remote access see the FAQ for MR reviewers)

added Run2-MCOverlay-output-changed label

changed the description

Hi @oda,

Before I drop the WIP status on this merge request, I wanted to check that these changes are OK with you. Could you take a look when you have a minute please?

Cheers,

John

Hi @jchapman ,

Thanks for the changes. Those look fine to me.

Cheers, Susumu

unmarked as a Work In Progress

Thanks for checking @oda. Let's see what the shifter thinks then.

added review-pending-level-1 label

The changes look ok from L1 point of view. The OverlayTier0Test_required-test failed which is expected according to the developer (the output of the test changed just slightly). Passing to L2 shifters to decide if it can be approved with this failing test.

L1 shifter

added review-pending-level-2 label and removed review-pending-level-1 label

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit f1c7c3e6

added sweep:ignore label