Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 148
    • Merge requests 148
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !20394

Improvement of pixel conditions (ATLASRECTS-4662)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Soshi Tsuno requested to merge stsuno/athena:atlasrects-4662.v3 into master Jan 16, 2019
  • Overview 66
  • Commits 16
  • Pipelines 7
  • Changes 41

In current code, the conditions data is interfaced by a tool, then, if the other tool needs the conditions data, that tool calls the "interface tool". That is, a tool calls a tool to access conditions data. This makes complicated structure of the code.

So, the suggestion raised in ATLASRECTS-4662 was to drop the interface tool, but directly handle the conditions data.

Based on this suggestion, we deleted the PixelDCSConditionsTool which was called from PixelLorentzAngleTool, PixelPropertiesTool, PixelConditionsSummaryTool. Now, they access the DCS data through the conditions algorithm directly.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: atlasrects-4662.v3