add EL::IWorker interface for EL::Worker
This is the first step of my efforts to restructure the workings of EventLoop. For now it means that users no longer directly access the Worker objects, but instead access it through the interface. Besides the usual benefits of using interfaces it also means that I can now add public member functions to the EL::Worker class without having to worry about users calling those methods.
This change should mostly be invisible to user code, though it will break code that passes Worker objects into another function. I don't believe that's command and I fixed the instances in the central packages where that happened, but somebody probably used that somewhere else as well.
In principle this should allow puting the Algorithm (and IWorker) class into the AnaAlgorithm package as well. That way user code doesn't have to depend on the EventLoop package at all anymore, which would be sort of nice.
Merge request reports
Activity
This merge request affects 4 packages:
- PhysicsAnalysis/D3PDTools/AnaAlgorithm
- PhysicsAnalysis/D3PDTools/EventLoop
- PhysicsAnalysis/D3PDTools/EventLoopAlgs
- PhysicsAnalysis/D3PDTools/MultiDraw
Adding @krumnack as watcher
added 21.2 Analysis review-pending-level-1 labels
CI Result FAILURE AnalysisBase AnalysisTop AthAnalysis AthDerivation externals cmake make required tests optional tests Full details available at NICOS MR-20395-2019-01-17-00-34
AnalysisBase: number of compilation errors 1, warnings 111
AnalysisTop: number of compilation errors 1, warnings 127
AthAnalysis: number of compilation errors 0, warnings 9
AthDerivation: number of compilation errors 0, warnings 52
For experts only: Jenkins output [CI-MERGE-REQUEST 32324] (for remote access see the FAQ for MR reviewers)This merge request affects 4 packages:
- PhysicsAnalysis/D3PDTools/AnaAlgorithm
- PhysicsAnalysis/D3PDTools/EventLoop
- PhysicsAnalysis/D3PDTools/EventLoopAlgs
- PhysicsAnalysis/D3PDTools/MultiDraw
Adding @krumnack as watcher
CI Result FAILURE AnalysisBase AnalysisTop AthAnalysis AthDerivation externals cmake make required tests optional tests Full details available at NICOS MR-20395-2019-01-17-01-56
AnalysisBase: number of compilation errors 1, warnings 21
AnalysisTop: number of compilation errors 2, warnings 19
AthAnalysis: number of compilation errors 0, warnings 5
AthDerivation: number of compilation errors 0, warnings 8
For experts only: Jenkins output [CI-MERGE-REQUEST 32328] (for remote access see the FAQ for MR reviewers)added 2 commits
This merge request affects 5 packages:
- PhysicsAnalysis/D3PDTools/AnaAlgorithm
- PhysicsAnalysis/D3PDTools/EventLoop
- PhysicsAnalysis/D3PDTools/EventLoopAlgs
- PhysicsAnalysis/D3PDTools/MultiDraw
- PhysicsAnalysis/TopPhys/QuickAna
Adding @krumnack as watcher
I guess @akraszna and @ksuruliz should sign off on this.
I should probably note that the alternative way to go about this would be to rename the old class to
WorkerImp
(or something like that) and then name the interface classWorker
. That would pretty much avoid any possible implications for user code, but would also violate our naming convention, and I don't believe there won't be a lot of implications for the user code.One could also think about whether to put at least the new class into the
AnaAlgorithm
package. As mentioned in the description that would reduce the need for user code to depend on theEventLoop
package.- Resolved by Attila Krasznahorkay
Meant to make the last comment a discussion. So, no merging until ASG signs off.
CI Result FAILURE AnalysisBase AnalysisTop AthAnalysis AthDerivation externals cmake make required tests optional tests Full details available at NICOS MR-20395-2019-01-17-23-53
AnalysisBase: number of compilation errors 1, warnings 59
AnalysisTop: number of compilation errors 1, warnings 53
AthAnalysis: number of compilation errors 0, warnings 9
AthDerivation: number of compilation errors 0, warnings 52
For experts only: Jenkins output [CI-MERGE-REQUEST 32362] (for remote access see the FAQ for MR reviewers)This merge request affects 5 packages:
- PhysicsAnalysis/D3PDTools/AnaAlgorithm
- PhysicsAnalysis/D3PDTools/EventLoop
- PhysicsAnalysis/D3PDTools/EventLoopAlgs
- PhysicsAnalysis/D3PDTools/MultiDraw
- PhysicsAnalysis/TopPhys/QuickAna
Adding @krumnack as watcher
CI Result FAILURE AnalysisBase AnalysisTop AthAnalysis AthDerivation externals cmake make required tests optional tests Full details available at NICOS MR-20395-2019-01-18-02-56
AnalysisBase: number of compilation errors 0, warnings 19
AnalysisTop: number of compilation errors 0, warnings 21
AthAnalysis: number of compilation errors 0, warnings 9
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 32368] (for remote access see the FAQ for MR reviewers)