Skip to content
Snippets Groups Projects

Create new unified Overlay transform

Merged Create new unified Overlay transform
tadej/athena:overlay/SCT_MT into master
All threads resolved!
Merged Tadej Novak requested to merge tadej/athena:overlay/SCT_MT into master
All threads resolved!

This MR creates a new unified Overlay transform targeting to merge MC and data overlay and be MT friendly. It is still in very early stages but SCT and truth overlays can be run with threads > 1. Please ignore commented-out code for now as things will probably still change a lot.

Current transforms should still work and the output should not change.

Edited by Tadej Novak

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak added 7 commits

    added 7 commits

    Compare with previous version

  • Tadej Novak unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Tadej Novak changed the description

    changed the description

  • Tadej Novak
    Tadej Novak @tadej ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Event/EventOverlay/EventOverlayJobTransforms
    • Event/EventOverlay/OverlayCommonAlgs
    • InnerDetector/InDetRawAlgs/InDetOverlay

    Adding @jchapman ,@tkharlam ,@ahaas ,@tadej as watchers

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark:

    Full details available at NICOS MR-20407-2019-01-18-12-50
    :warning: Athena: number of compilation errors 0, warnings 2
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    For experts only: Jenkins output [CI-MERGE-REQUEST 32396] (for remote access see the FAQ for MR reviewers)

  • Sergio Grancagnolo resolved all discussions

    resolved all discussions

  • G
    Sergio Grancagnolo @grancagn ·
    Developer

    Code looks fine, approving.

  • Sergio Grancagnolo added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit c3bc9417

    mentioned in commit c3bc9417

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply