Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 167
    • Merge requests 167
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !20632

CMake Updates, master branch (2019.01.25.)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Attila Krasznahorkay requested to merge akraszna/athena:CMakeUpdates-master-20190125 into master Jan 25, 2019
  • Overview 14
  • Commits 5
  • Pipelines 1
  • Changes 15

This is a follow-up from !20525 (merged) and !20604 (merged).

While making sure that I would be able to compile packages that use tdaq-common on top of today's nightly, I found that I still forgot about updating a few things. Simply doing git grep "_ROOT}", I now tried to update all occurrences of "old style" variable usage to the new naming scheme.

On the VP1 packages I decided to do a bit more, and clean up the packages that used QT5_ROOT (for no good reason even in the past). @rbianchi, @emoyse, you guys should definitely have a look. The updates at least didn't break the build of these packages for me...

While doing this, I also found some additional issues in AthDataQuality, which I tried to now fix.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: CMakeUpdates-master-20190125