Added JVT moment to FTK jet collections, some monitoring hists
FTK/FTKRefit jet collections will now get JVT computed. Validated that this is written to AOD and implemented a couple of monitoring histograms that have been verified in AOD->NTUP_PHYSVAL.
In the process, I made a couple of other minor fixes:
- Change HTLJetMonTool behaviour to warn if a jet collection is not found, but proceed with filling histograms for all collections that have been found. This facilitates testing of a few chains at a time, and will forestall cases where a single collection was misconfigured, leading to all of the jet monitoring being disabled.
- Corrected typos in jet v8 menu additions
- Removed unused variables from JetVertexTaggerTool
(Partially) addresses ATR-19217, builds on ATR-16020
Tagged for sweep to master, but that will most likely fail...
Merge request reports
Activity
Fixed clash & incorporated other fixes from @jchapman
added 4 commits
-
515cb3d8...c753e219 - 3 commits from branch
atlas:21.3
- c8d37c20 - Merge branch '20.3' of https://gitlab.cern.ch:8443/atlas/athena into 21.3-FTK_JVT
-
515cb3d8...c753e219 - 3 commits from branch
added 21.3 JetEtmiss Reconstruction review-pending-level-1 labels
❎ CI Result FAILUREAthena externals ✅ cmake ✅ make ✅ required tests ⭕ optional tests ✅ Full details available at NICOS MR-20749-2019-01-30-12-18
⚠ Athena: number of compilation errors 0, warnings 2
📝 CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33002]The CI fails and is probably related to:
RDOtoRDOTrigger 11:50:08 AlgorithmManager ERROR Algorithm of type TrigHLTJetHypo_JetAttrs is unknown (No factory available). RDOtoRDOTrigger 11:50:08 AlgorithmManager ERROR Unknown error 18446744072367300269 RDOtoRDOTrigger 11:50:08 AlgorithmManager ERROR More information may be available by setting the global jobOpt "PluginDebugLevel" to 1 RDOtoRDOTrigger 11:50:08 TrigSteer_HLT WARNING createSubAlgorithm: 'TrigHLTJetHypo_JetAttrs/TrigHLTJetHypo_JetAttrs_subj360Iwidth' FAILED RDOtoRDOTrigger 11:50:08 TrigSteer_HLT ERROR failed to create sequence: sequence has no algorithms. Output type: EF__1056762905149652563_HLThypo2_jetattrs_j0_a10t_lcw_jes_subj360Iwidth RDOtoRDOTrigger 11:50:08 TrigSteer_HLT FATAL Signature: (TE = EF__1056762905149652563_HLThypo2_jetattrs_j0_a10t_lcw_jes_subj360Iwidth) : Could not find matching sequence for output TE.
Could you please also update the copyright statements in the files affecting this MR?
Thanks, Johannes (L1)
Edited by Johannes Mellenthinadded review-user-action-required label and removed review-pending-level-1 label
added 33 commits
-
c8d37c20...d15e6f2d - 30 commits from branch
atlas:21.3
- 4e5e07e9 - Fix formatting of histogram booking
- 3d4cfbce - correct typos in requested FTK jet chains
- 3ea75591 - Merge branch '21.3' of https://gitlab.cern.ch:8443/atlas/athena into 21.3-FTK_JVT
Toggle commit list-
c8d37c20...d15e6f2d - 30 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
❎ CI Result FAILUREAthena externals ✅ cmake ✅ make ✅ required tests ⭕ optional tests ✅ Full details available at NICOS MR-20749-2019-02-01-02-40
⚠ Athena: number of compilation errors 0, warnings 1
📝 CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33110]Hi @khoo, the q-test is failing. Could you have a look?
Tadej (L2)
added review-user-action-required label and removed review-pending-level-1 label
added 2 commits
added review-pending-level-1 label and removed review-user-action-required label
✅ CI Result SUCCESSAthena externals ✅ cmake ✅ make ✅ required tests ✅ optional tests ✅ Full details available at NICOS MR-20749-2019-02-01-23-27
⚠ Athena: number of compilation errors 0, warnings 166
📝 CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33169]