HltEventLoopMgr: fixes to startup sequence and SOR handling
Changes to CMakeLists.txt
- Link component library against regular library
- Remove unused dependencies
Changes in HltEventLoopMgr
:
-
start()
should not be used in the EventLoopMgr as it is executed beforeprepareForRun
. Moved the relevant code there. - Also added back calls to
sysBeginRun
(soon to be deprecated) and fire theBeginRun
incident in order to stay in sync with offline. - Make SORPath configurable via property in
HltEventLoopMgr
- Store the current "run context" in a private member. This is useful for interacting with the IOV(Db)Svc during the start sequence.
Major cleanup of TrigSORFromPtreeHelper
:
- Inherit from
AthMessaging
to get access to the regular messaging macros. - Use
ATH_CHECK
where it makes sense - Avoid passing around pointers to the
SOR
object by merging a few small methods into one. - Remove a several
typedef
s andusing
declarations - Add
eventID(ptree)
method to create anEventIDBase
from the RunParams ptree.
TrigSORFromPtreeHelper
are large and it's probably easier to just look at the full file rather than the diff.
Merge request reports
Activity
added Trigger master review-pending-level-1 labels
I don't have any comments for the HltEventLoopMgr changes, they look good to me. But I have a thought on the helper. In principle, this doesn't have to be a class, since the object doesn't have any state. It doesn't hold any data and never modifies the only two private members - sorname and detstore pointer. In fact, it only has const methods. The helper could be a namespace and take sorname and detstore pointer as arguments where needed. The only concern here is the context for messaging, but we could also use
REPORT_MESSAGE_WITH_CONTEXT
instead ofATH_MSG...
. On the other hand, I'm not sure if there's any big gain in converting it to a namespace.✅ CI Result SUCCESSAthena AthSimulation externals ✅ ✅ cmake ✅ ✅ make ✅ ✅ required tests ✅ ✅ optional tests ☁ ✅ Full details available at NICOS MR-20762-2019-01-30-22-36
⚠ Athena: number of compilation errors 0, warnings 1
✅ AthSimulation: number of compilation errors 0, warnings 0
📝 CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33033]@rbielski thanks for looking at the code. I was actually wondering if I should covert the helper into a proper tool but then that seemed a bit overkill. I think I prefer the class, but as you say, it really doesn't matter much here.
For the non-const
overwrite
, this works because I think the handles don't follow the const-correctness yet, i.e. the pointer to StoreGate returned by the handle is non-const here. I should probably just remove theconst
from the method as we don't really need const-ness. I will do this in my next MR.Thanks, @fwinkl, I'm fine with accepting this MR as it is.
added review-approved label and removed review-pending-level-1 label
mentioned in commit 0cb9f0ce
added sweep:ignore label
mentioned in merge request !20907 (merged)