Skip to content
Snippets Groups Projects

BeamEffectsCongfig rewritten to new style

Merged Daniel Louis Noel requested to merge dnoel/athena:NewComponentAccumulatorSyntax into master

Output is the same as running the old style config. New flags added in SimulationFlags.py.

Issue with "VERBOSE" output - not printing currently.

Merge request reports

Checking pipeline status.

Merged by Walter LamplWalter Lampl 5 years ago (Feb 7, 2019 10:07am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • John Derek Chapman
  • Thanks for these changes @dnoel. They look good to me apart from the minor tweaks above. One other suggestion so that we have a common naming convention within simulation would be to rename the makeXyz methods to XyzCfg. This can happen later though.

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark:

    Full details available at NICOS MR-20819-2019-02-01-16-23
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33137]

  • Hi @dnoel ,

    Please resolve the discussions and then re-request the L1 review.

    Cheers, Clara (L1)

  • added 1 commit

    • d47c3bd9 - Made suggested changes for Merge request

    Compare with previous version

  • This merge request affects 1 package:

    • Simulation/BeamEffects

    Adding @jchapman ,@vpascuzz as watchers

  • Thank you for all the comments! I am unsure whether VertexBeamCondPositioner() is being called correctly now, otherwise the rest should be good to go.

  • John Derek Chapman resolved all discussions

    resolved all discussions

  • Thanks @dnoel. That looks good to me now.

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark:

    Full details available at NICOS MR-20819-2019-02-05-02-07
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33296]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading