BeamEffectsCongfig rewritten to new style
Output is the same as running the old style config. New flags added in SimulationFlags.py.
Issue with "VERBOSE" output - not printing currently.
Merge request reports
Activity
added Simulation master review-pending-level-1 labels
- Resolved by Daniel Louis Noel
- Resolved by John Derek Chapman
- Resolved by Daniel Louis Noel
- Resolved by Daniel Louis Noel
- Resolved by Daniel Louis Noel
- Resolved by Daniel Louis Noel
Thanks for these changes @dnoel. They look good to me apart from the minor tweaks above. One other suggestion so that we have a common naming convention within simulation would be to rename the
makeXyz
methods toXyzCfg
. This can happen later though.CI Result SUCCESS Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20819-2019-02-01-16-23
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33137] added review-user-action-required label and removed review-pending-level-1 label
added review-pending-level-1 label and removed review-user-action-required label
Thanks @dnoel. That looks good to me now.
CI Result SUCCESS Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-20819-2019-02-05-02-07
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33296] - Resolved by Daniel Louis Noel