Complete migration to V2 of TrigComposite Aux
!20600 (merged) missed the one-letter change to put this V2 EDM change into action.
This MR remedies this.
TrigCostMTSvc 0 0 WARNING Failed to append one or more details to trigger cost TC
ERROR xAOD::ByteStreamAuxContainer_v1::getData Unknown variable type (NSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE) requested
xAOD::TrigComposite_v1::setDetail ERROR Internal logic error found: [SG::ExcBadAuxVar: Attempt to retrieve nonexistent aux data item `::store' (390).]
ERROR xAOD::ByteStreamAuxContainer_v1::getData Unknown variable type (s) requested
xAOD::TrigComposite_v1::setDetail ERROR Internal logic error found: [SG::ExcBadAuxVar: Attempt to retrieve nonexistent aux data item `::view' (391).]
...
Caused by a move to a fully template-ed interface and removal of type massaging.
I touch a file in TrigUpgradeTest
this time to trigger the unit tests. This wasn't done in !20600 (merged) which is why it didn't get caught.
Marking urgent as causes an error in CI
Merge request reports
Activity
This merge request affects 2 packages:
- Event/xAOD/xAODTrigger
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbianchi as watcher
added EDM Trigger master review-pending-level-1 labels
mentioned in merge request !20705 (merged)
❎ CI Result FAILUREAthena AthSimulation externals ✅ ✅ cmake ✅ ✅ make ✅ ✅ required tests ⭕ ✅ optional tests ☁ ✅ Full details available at NICOS MR-20959-2019-02-07-18-25
⚠ Athena: number of compilation errors 0, warnings 3
✅ AthSimulation: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST 33481]added 1 commit
- feecd1c8 - Bugfix. TrigComposite V2 is now sensitive to the sign of stored primitives.
This merge request affects 3 packages:
- Event/xAOD/xAODTrigger
- Trigger/TrigMonitoring/TrigCostMonitorMT
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbianchi as watcher
❎ CI Result FAILUREAthena AthSimulation externals ✅ ✅ cmake ✅ ✅ make ✅ ✅ required tests ⭕ ✅ optional tests ☁ ✅ Full details available at NICOS MR-20959-2019-02-08-02-29
⚠ Athena: number of compilation errors 0, warnings 3
✅ AthSimulation: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST 33511]mentioned in merge request !20939 (merged)
added review-user-action-required label and removed review-pending-level-1 label
This merge request affects 3 packages:
- Event/xAOD/xAODTrigger
- Trigger/TrigMonitoring/TrigCostMonitorMT
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbianchi as watcher
added review-pending-level-1 label and removed review-user-action-required label
added 1 commit
- 4c5c7850 - Update references, V2 EDM causes smaller bytestream packing for these specific use cases
This merge request affects 3 packages:
- Event/xAOD/xAODTrigger
- Trigger/TrigMonitoring/TrigCostMonitorMT
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbianchi as watcher
Thanks @cnellist
All the CI tests ran to completion this time, and the only remaining issue was with the references
ERROR: egammaRunData.log and ../share/egammaRunData.ref differ
as this change saves us some space in the BS.I have updated the references.
As this MR is holding up other ones due to it fixing a CI problem, I might still ask that the master release coordinator accepts this without waiting for the just-triggered round of CI such that I can restart CI on other held up trigger MRs.
added review-pending-level-2 label and removed review-pending-level-1 label
added review-approved label and removed review-pending-level-2 label