Trigger Run 3 Cost Monitoring Output

• Trigger cost monitoring now outputs string hashes rather than strings - large space saving
• Some basic code is added to allow for easy exporting and importing of hash dictionaries, until the proper TrigConf R3 service is in place.
• The new CostMonSvc interface is tidied up some more
• Following from !20600 (merged), we can now decorate 64bit integers, the timestamps no longer need to be packed into two ints.
• A way of accessing a RoI descriptor inside a View from just the Context is added. This will be developed on more in the future.

added 1 commit

• c33946f9 - Add RoI to event context

Compare with previous version

added 206 commits

• c33946f9...2f3019a9 - 204 commits from branch atlas:master
• df6bd7c5 - simplify TrigTimeStamp, now that we can decorate a uint64_t directly
• db986807 - Merge remote-tracking branch 'upstream/master' into TrigCostMonOutputAndProcessing

Compare with previous version

Jenkins please retry a build

This merge request affects 6 packages:

• Control/AthenaKernel
• Trigger/TrigConfiguration/TrigConfHLTData
• Trigger/TrigMonitoring/TrigCostMonitorMT
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigTools/TrigTimeAlgs
• Trigger/TrigValidation/TrigUpgradeTest

Adding @ssnyder ,@rbianchi as watchers

added Core Trigger master labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20994-2019-02-08-22-02
Athena: number of compilation errors 0, warnings 3
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 33569]

unmarked as a Work In Progress

changed title from WIP Trig cost mon output and processing to Trigger Run 3 Cost Monitoring Output

changed the description

added review-pending-level-1 label

Hi @tamartin, see one very minor comment above. Can the discussion with Charles and Scott be resolved?

Cheers, Timo (L1)

added 2 commits

• f4214108 - RoI descriptor from ATLAS ExtendedEventContext
• 927eae69 - whitespace and adding RoI to extension

Compare with previous version

This merge request affects 6 packages:

• Control/AthenaKernel
• Trigger/TrigConfiguration/TrigConfHLTData
• Trigger/TrigMonitoring/TrigCostMonitorMT
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigTools/TrigTimeAlgs
• Trigger/TrigValidation/TrigUpgradeTest

Adding @ssnyder ,@rbianchi as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20994-2019-02-12-19-36
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 33689]

Hey @tamartin

After your last commit the unittest failed: 1286 - TrigUpgradeTest_muRunData_ctest (Failed) 1287 - TrigUpgradeTest_muMenu_ctest (Failed)

Can you please have a look?

Kira (L1)

added review-user-action-required label and removed review-pending-level-1 label

Asked on !20735 (merged)

resolved all discussions

Jenkins please retry a build

This merge request affects 6 packages:

• Control/AthenaKernel
• Trigger/TrigConfiguration/TrigConfHLTData
• Trigger/TrigMonitoring/TrigCostMonitorMT
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigTools/TrigTimeAlgs
• Trigger/TrigValidation/TrigUpgradeTest

Adding @ssnyder ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20994-2019-02-14-19-01
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 33832]

added review-pending-level-2 label and removed review-pending-level-1 label

Looks fine to me now, so approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 5e18b807

added sweep:ignore label