Skip to content

Remove const_cast of SCT_ClusterOnTrackCnv_p2.cxx

Susumu Oda requested to merge oda/athena:master-SCT_ClusterOnTrackCnv_p2 into master

Remove const_cast of SCT_ClusterOnTrackCnv_p2.cxx by adding and using a new getHashAndIndex method.

  • InnerDetector/InDetEventCnv/InDetEventTPCnv/src/InDetRIO_OnTrack/SCT_ClusterOnTrackCnv_p2.cxx
    • Remove const_cast by using getHashAndIndex method instead of prepareRIO_OnTrack.
    • Code cleanup
  • Tracking/TrkEventCnv/TrkEventCnvTools/TrkEventCnvTools/EventCnvSuperTool.h
    • Add const getCnvTool method.
  • Tracking/TrkEventCnv/TrkEventCnvTools/TrkEventCnvTools/IEventCnvSuperTool.h
    • Add getHashAndIndex method and const getCnvTool method.
  • Tracking/TrkEventCnv/TrkEventCnvTools/TrkEventCnvTools/IEventCnvSuperTool.icc
    • Implement getHashAndIndex method.
  • Tracking/TrkEventCnv/TrkEventCnvTools/TrkEventCnvTools/ITrkEventCnvTool.h
    • Add getHashAndIndex method.
  • Tracking/TrkEventCnv/TrkEventCnvTools/TrkEventCnvTools/ITrkEventCnvTool.icc
    • Implement getHashAndIndex method.
    • Code cleanup
  • Tracking/TrkEventCnv/TrkEventCnvTools/src/EventCnvSuperTool.cxx
    • Add const getCnvTool method.
  • InnerDetector/InDetEventCnv/InDetEventCnvTools/InDetEventCnvTools/InDetEventCnvTool.h
    • Code cleanup
  • InnerDetector/InDetEventCnv/InDetEventCnvTools/src/InDetEventCnvTool.cxx
    • Code cleanup
+ Tracking/TrkEventCnv/TrkEventCnvTools
+ Tracking/TrkEventCnv/TrkEventAthenaPool
+ Tracking/TrkEventCnv/TrkEventTPCnv
+ InnerDetector/InDetEventCnv/InDetEventCnvTools
+ InnerDetector/InDetEventCnv/InDetEventTPCnv
+ MuonSpectrometer/MuonCnv/MuonEventCnvTools
+ MuonSpectrometer/MuonCnv/MuonEventTPCnv

were needed to be recompiled.

RunTier0Tests.py did not find output differences but found more memory leak in ESDtoAOD of q431. RunTier0Tests.log. I'm not sure why this happens. --> I ran valgrind with the job of ESDtoAOD of q431 but could not find any suspicious memory leaks related to this MR.

Edited by Susumu Oda

Merge request reports