Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 192
    • Merge requests 192
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !21024

Merged
Created Feb 10, 2019 by Soshi Tsuno@stsunoDeveloper

Conditions migration for pixel charge calibration (ATLASRECTS-4565)

  • Overview 85
  • Commits 30
  • Pipelines 11
  • Changes 78

This is the last piece of the conditions migration for athenaMT.

The InnerDetector/InDetConditions/PixelConditionsServices/src/PixelCalibSvc.cxx is deleted.

Note that due to the rounding issue (string to float), the result will change from the HITS level. Thus, the reference should be updated once this is merged.

Checking why the threshold values in the conditions DB are so different from old reading scheme to new reading scheme is not simple as done via job option, since there is no test algorithm to dump out the threshold values from the conditions in the old method.

But for instance, see

https://gitlab.cern.ch/atlas/athena/blob/master/InnerDetector/InDetConditions/PixelCoralClientUtils/PixelCoralClientUtils/PixelCalibData.hh#L121

Clearly, the read value is not same as simple reading scheme as we propose in this MR. InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelChargeCalibCondAlg.cxx

The values obtained from the old method seems wrong... We correct it in this MR.

Edited Apr 05, 2019 by Soshi Tsuno
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: atlasrects-4565.v2