Skip to content
Snippets Groups Projects

Conditions migration for pixel charge calibration (ATLASRECTS-4565)

Merged Soshi Tsuno requested to merge stsuno/athena:atlasrects-4565.v2 into master

This is the last piece of the conditions migration for athenaMT.

The InnerDetector/InDetConditions/PixelConditionsServices/src/PixelCalibSvc.cxx is deleted.

Note that due to the rounding issue (string to float), the result will change from the HITS level. Thus, the reference should be updated once this is merged.

Checking why the threshold values in the conditions DB are so different from old reading scheme to new reading scheme is not simple as done via job option, since there is no test algorithm to dump out the threshold values from the conditions in the old method.

But for instance, see

https://gitlab.cern.ch/atlas/athena/blob/master/InnerDetector/InDetConditions/PixelCoralClientUtils/PixelCoralClientUtils/PixelCalibData.hh#L121

Clearly, the read value is not same as simple reading scheme as we propose in this MR. InnerDetector/InDetConditions/PixelConditionsAlgorithms/src/PixelChargeCalibCondAlg.cxx

The values obtained from the old method seems wrong... We correct it in this MR.

Edited by Soshi Tsuno

Merge request reports

Pipeline #811384 passed

Pipeline passed for 99df58d3 on stsuno:atlasrects-4565.v2

Merged by Vakhtang TsulaiaVakhtang Tsulaia 5 years ago (Apr 16, 2019 7:07pm UTC)

Merge details

  • Changes merged into with a7ec5a15.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 18 packages:

    • InnerDetector/InDetCalibAlgs/PixelCalibAlgs
    • InnerDetector/InDetConditions/PixelConditionsAlgorithms
    • InnerDetector/InDetConditions/PixelConditionsData
    • InnerDetector/InDetConditions/PixelConditionsServices
    • InnerDetector/InDetConditions/PixelConditionsTools
    • InnerDetector/InDetDetDescr/PixelGeoModel
    • InnerDetector/InDetDigitization/FastSiDigitization
    • InnerDetector/InDetDigitization/PixelDigitization
    • InnerDetector/InDetDigitization/PixelRadDamDigitization
    • InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetSLHC_Example
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetMonitoring/SCT_Monitoring
    • InnerDetector/InDetRecTools/PixelToTPIDTool
    • InnerDetector/InDetRecTools/SiClusterizationTool
    • Trigger/TrigTools/TrigOnlineSpacePointTool
    • Trigger/TrigValidation/TrigUpgradeTest

    Adding @jchapman ,@oda ,@kzoch ,@ibragimo as watchers

  • CI Result FAILURE

    Athena AthSimulation
    externals
    cmake
    make
    required tests
    optional tests

    Full details available at NICOS MR-21024-2019-02-11-03-39
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST 33608]

  • Soshi Tsuno added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 18 packages:

    • InnerDetector/InDetCalibAlgs/PixelCalibAlgs
    • InnerDetector/InDetConditions/PixelConditionsAlgorithms
    • InnerDetector/InDetConditions/PixelConditionsData
    • InnerDetector/InDetConditions/PixelConditionsServices
    • InnerDetector/InDetConditions/PixelConditionsTools
    • InnerDetector/InDetDetDescr/PixelGeoModel
    • InnerDetector/InDetDigitization/FastSiDigitization
    • InnerDetector/InDetDigitization/PixelDigitization
    • InnerDetector/InDetDigitization/PixelRadDamDigitization
    • InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetSLHC_Example
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetMonitoring/SCT_Monitoring
    • InnerDetector/InDetRecTools/PixelToTPIDTool
    • InnerDetector/InDetRecTools/SiClusterizationTool
    • Trigger/TrigTools/TrigOnlineSpacePointTool
    • Trigger/TrigValidation/TrigUpgradeTest

    Adding @jchapman ,@oda ,@kzoch ,@ibragimo as watchers

  • CI Result FAILURE

    Athena AthSimulation
    externals
    cmake
    make
    required tests
    optional tests

    Full details available at NICOS MR-21024-2019-02-12-01-34
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST 33656]

  • Hey @stsuno

    The unit test is still failing and I'm also not sure if the failing Tier0 Overlay test is actually the behaviour that you decribed since it doesn't fail on differences but on retrieving some information. Could you please have a look?

    Kira (L1)

  • Soshi Tsuno added 188 commits

    added 188 commits

    Compare with previous version

  • This merge request affects 18 packages:

    • InnerDetector/InDetCalibAlgs/PixelCalibAlgs
    • InnerDetector/InDetConditions/PixelConditionsAlgorithms
    • InnerDetector/InDetConditions/PixelConditionsData
    • InnerDetector/InDetConditions/PixelConditionsServices
    • InnerDetector/InDetConditions/PixelConditionsTools
    • InnerDetector/InDetDetDescr/PixelGeoModel
    • InnerDetector/InDetDigitization/FastSiDigitization
    • InnerDetector/InDetDigitization/PixelDigitization
    • InnerDetector/InDetDigitization/PixelRadDamDigitization
    • InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetSLHC_Example
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetMonitoring/SCT_Monitoring
    • InnerDetector/InDetRecTools/PixelToTPIDTool
    • InnerDetector/InDetRecTools/SiClusterizationTool
    • Trigger/TrigTools/TrigOnlineSpacePointTool
    • Trigger/TrigValidation/TrigUpgradeTest

    Adding @jchapman ,@oda ,@kzoch ,@ibragimo as watchers

  • CI Result FAILURE

    Athena AthSimulation
    externals
    cmake
    make
    required tests
    optional tests

    Full details available at NICOS MR-21024-2019-02-13-21-47
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST 33768]

  • @stsuno , three unit tests failed: 1288 - TrigUpgradeTest_muRunData_ctest (Failed) 1289 - TrigUpgradeTest_muMenu_ctest (Failed) 1298 - TrigUpgradeTest_NewJO_ctest (Failed)

    Is it connected with your changes or you think a restart will help?

    L1 shifter

  • Author Contributor

    Hello,

    I think this error is not relevant to Pixel.

    I think this seems comes from other part (Trigger)...

    Py:Athena INFO Importing TriggerMenuMT.HLTMenuConfig.Menu.DictFromChainName Py:ConfigurableDb INFO Read module info for 5457 configurables from 1119 genConfDb files Py:ConfigurableDb INFO No duplicates have been found: that's good ! Py:Configurable ERROR attempt to add a duplicate (ServiceManager.ProxyProviderSvc) ... dupe ignored EventInfoMgtInit: Got release version Athena-22.0.1 Py:Configurable ERROR attempt to add a duplicate (ServiceManager.EventPersistencySvc) ... dupe ignored Py:Configurable ERROR attempt to add a duplicate (ServiceManager.ProxyProviderSvc) ... dupe ignored Py:IOVDbSvc.CondDB INFO Setting up conditions DB access to instance OFLP200 Py:Configurable ERROR attempt to add a duplicate (ServiceManager.PoolSvc) ... dupe ignored

    Cheers, Soshi

  • Looks to me some /cvmfs problem during build, so restarting.....

    Pavol [as L2 MR shifter]

  • Jenkins please retry a build

  • This merge request affects 18 packages:

    • InnerDetector/InDetCalibAlgs/PixelCalibAlgs
    • InnerDetector/InDetConditions/PixelConditionsAlgorithms
    • InnerDetector/InDetConditions/PixelConditionsData
    • InnerDetector/InDetConditions/PixelConditionsServices
    • InnerDetector/InDetConditions/PixelConditionsTools
    • InnerDetector/InDetDetDescr/PixelGeoModel
    • InnerDetector/InDetDigitization/FastSiDigitization
    • InnerDetector/InDetDigitization/PixelDigitization
    • InnerDetector/InDetDigitization/PixelRadDamDigitization
    • InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetSLHC_Example
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetMonitoring/SCT_Monitoring
    • InnerDetector/InDetRecTools/PixelToTPIDTool
    • InnerDetector/InDetRecTools/SiClusterizationTool
    • Trigger/TrigTools/TrigOnlineSpacePointTool
    • Trigger/TrigValidation/TrigUpgradeTest

    Adding @jchapman ,@oda ,@kzoch ,@ibragimo as watchers

  • CI Result FAILURE

    Athena AthSimulation
    externals
    cmake
    make
    required tests
    optional tests

    Full details available at NICOS MR-21024-2019-02-14-23-08
    Athena: number of compilation errors 0, warnings 2
    AthSimulation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST 33849]

  • Hi @stsuno, as this MR seems clear to me, could you run the overlay test RunTier0Tests.py -o and put the output RDO file somewhere accessible so we can update the references.

    Thanks, Tadej

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading