Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 155
    • Merge requests 155
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !21080

Second pass for ATLJETMET-1078,ATLASRECTS-4828,ATLASRECTS-4827

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:xAOD__TYPE__Dict into master Feb 12, 2019
  • Overview 9
  • Commits 4
  • Pipelines 4
  • Changes 32

If my tests are not mistaken taking out the ObjectType from the xAOD namespace reduces the number of shared libraries .so actually loaded due to the dictionary for this enum.

Now there were a couple of issues since clients expect xAOD::Type:: while we now have xAODType. aliasing the namespace should help basically expanding on a suggestion from @khoo.

Mentioning also @mhodgkin and @ssnyder

Then there are some additions on python loading the dict etc (many files but not many line changed), these can be also problematic , I guess the tests will let us know.

Edited Feb 14, 2019 by Christos Anastopoulos
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: xAOD__TYPE__Dict