Skip to content

Reorganise RPC and TGC overlay code

Tadej Novak requested to merge tadej/athena:overlay/idc-simplification into master

This is a first step of cleaning-up the Identifiable Container overlay code, starting with RPC and TGC. The overall goal is to make the inheritance structure simpler and code more understandable.

The debug print is moved in a separate file as it is in common with all of the IDC overlay algorithms.

A new class IDC_MuonOverlayBase is introduced as a base muon overlay class. It inherits directly from AthAlgorithm. There is one base overlay method which has two helper functions differentiating the structure of the stored collection. For now only multi-hit containers have been updated to reduce the amount of changes in the MR.

IDC_MultiHitOverlayBase has been renamed to IDC_MultiHitOverlayCommon and is no longer a class. The files contain the implementation of template functions for to merge collections and RDOs for multi-hit identifiable containers.

All of the code has been cleaned-up and updated with the new bkg/signal/output overlay naming conventions (ATLASSIM-3821).

Unfortunately GitLab considers all files replaced. Shifters should feel free to review the code in general.

/cc @jchapman

Edited by Tadej Novak

Merge request reports