Added handy accessors to CA to get single/main components

getEventAlgo, getService getPublicTool now can obtain no argument, in this case return the main component, ambiguity like missing component, to many components cause exception.

When moving away from returning a tuple, there was a suggestion to also be able to return a private tool in the accumulator, as well, for cases when we configure more complicated private tools.

added 1 commit

• 0d940013 - CA also stores private tools

Compare with previous version

Hi Jovan, indeed. Added it. Shold they be merged as well?

I am new to the configuration changes, but I assume there is no need for merging private tools, since they are only useful if you add them to an algorithm or service. I don't think you really need more than one private tool, either.

added 1 commit

• d9b331ba - fixed obvious mistakes

Compare with previous version

resolved all discussions

changed title from WIP Added handy accessors to CA to get sinegle/main components to WIP Added handy accessors to CA to get single/main components

changed the description

Thanks @rtombs for spotting these mistakes

unmarked as a Work In Progress

changed the description

This merge request affects 1 package:

• Control/AthenaConfiguration

Adding @ssnyder ,@rbianchi as watchers

added Core master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21167-2019-02-19-12-16
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 34064]

Looks fine. Approving!

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 85dd2050