Skip to content

GitLab

Merged
Created by John Derek Chapman@jchapmanDeveloper

Preparations for running CscOverlay in MT Overlay jobs

This merge request contains three main changes:

    1. Move CscDigitizationTool out of CscOverlay Algorithm. Having CscOverlay own and call the tools which create its inputs causes the MT scheduling code to get think there is a loop in its input and output dependencies. For this reason it is better to call CscDigitizationTool from a separate CscDigitBuilder Algorithm which can run before CscOverlay. This change alters the Overlay output as the CscDigitizationTool name changes when it moves to the separate Algorithm. This name is used to set the random seed. (Reference file updated.)
    1. Add new CscOverlayDigitToRDO Algorithm to convert signal CSC Digits to CSC RDOs. This change was also made to avoid the MT scheduling code thinking that CscOverlay has a loop in its input and output dependencies.
    1. Standardized CscOverlay input/ouput property names.
    1. Drop dependency of CscOverlay on MuonOverlayBase. This was no-longer needed.

CscOverlayDigitToRDO may end up being a temporary measure (see comments in the commits and ATLASSIM-3813), but it was the cleanest way to separate out the hard-scatter CSC RDO creation.

Edited by John Derek Chapman