Skip to content

IOVDbSvc: Fix re-load logic in signalBeginRun

Frank Winklmeier requested to merge fwinkl/athena:iovdbsvc_signalBeginRun into master

Decide based on the run number if a reload of folders should be done in online mode rather than counting the number of invocations. The latter may not work correctly as we have multiple calls to signalBeginRun in a job (e.g. from IOVSvcTool, TagInfoMgr, HltEventLoopMgr) and this leads to a re-load of the folder already for the first run.

It took me a while to figure out what this code was supposed to do in the first place until I found this 10 year old SVN commit: https://svnweb.cern.ch/trac/atlasoff/changeset/79506/Database/IOVDbSvc/trunk/src/IOVDbSvc.cxx which explains the purpose. I think my fix is functionally equivalent assuming the only use-case was to update the folders on run number changes.

cc @sroe

Merge request reports