Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !21254

WIP: Adding missing pieces to CaloTopoClusterConfig.py

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Teng Jian Khoo requested to merge khoo/athena:master-CaloTopoClusterCfg into master Feb 18, 2019
  • Overview 1
  • Commits 14
  • Pipelines 0
  • Changes 16

Copied over most of the missing configuration from CaloTopoClusterTopoGetter.py into CaloTopoClusterConfig.py. So far only tested on data and not yet enabling the digitruth or calibration hit moments.

In the process, created LArHVScaleConfig.py to set up the HV scale corrections. Also merged in changes from !21251 (merged), which are clearly needed.

@wlampl, @pavol, FYI. I'd appreciate some input on what further restructuring is desirable. E.g. the LArHVScaleConfig might have parts that fit better in upstream config helpers that could be shared with other tools etc. As for CaloTopoClusterConfig.py, this might also want to be split up into uncalibrated topoclusters and calibrated, or incorporate more steering from the ConfigFlags.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-CaloTopoClusterCfg