Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !21340

WIP: ComponentAccumulator configuration for SCT and Pixel digitization

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Rupert Tombs requested to merge rtombs/athena:DigitizationNewConfig into master Feb 21, 2019
  • Overview 9
  • Commits 58
  • Pipelines 2
  • Changes 31

Define new style replacements for SCT_DigitizationConfig.py and PixelDigitizationConfig.py

With ConfigFlags definitions utilities and dependencies, including *ToolSetup replacements

Also makes minor updates to BCM_Digitization.

Questions:

SCT_ReadCalibChipDataConfig.py lines 22-25: ComponentAccumulator folder tools do not have the tag features previously used here. Are these okay to neglect?

SCT_DigitizationConfig.py lines 75-83: To avoid migrating the ExperimentalDigi flag, doDetailedSurfChargesGen has not been migrated here. Is this still needed?

PixelCablingConfigNew.py line 60: Is this DBM logic correct?

OverlayConfigFlags.py line 15: Overlay.EventStore flag is questionable.

Edited Mar 11, 2019 by Rupert Tombs
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: DigitizationNewConfig