Skip to content

Tidying of CSC Overlay code based in ATLASSIM-3813

John Derek Chapman requested to merge jchapman/athena:CscOverlayNsampleCleanup_ATLASSIM-3813_master into master

Switched to using a simpler Algorithm for CSC Digit to RDO conversion during Overlay. Based on the discussion in ATLASSIM-3813 it is no longer necessary to support producing CSCRDOs with two samples rather than the current standard of four, so we can switch to a simpler Digit to RDO conversion Algorithm which only supports the latter.

Removed obsolete CscOverlayDigitToRDO Algorithm.

Dropped unnecessary checks on CscRawData::numSamples() from CscOverlay::execute.

Further tidying of CscOverlay Algorithm. Code now returns StatusCode::FAILURE if newly-created SG::Read/WriteHandles are invalid. Dropped obsolete code using auto_ptr. Make overlayContainer and mergeCollections methods private.

Merge request reports