Hi,
The changes made are for: ATR-19355: Implement L1Topo trigger 0INVM10-3MU4ab ATR-18815: Implemet L1topo trigger 0INVM10-0DR15-EM8abi-MU10ab and 0INVM10-0DR15-EM12abi-MU6ab ATR-17328: 1DISAMB-J25ab-0DR28-TAU20abi-TAU12abi -> 2DISAMB-J25ab-0DR28-TAU20abi-TAU12abi
Tagging @aranzazu and @jmontejo for review:
As suggested I reordered the triggers in TriggerMenu/python/l1topomenu/Menu_MC_pp_v8.py to find the available slots and added the three triggers and corresponding JIRA numbers accordingly.
I'd also appreciate a double check of the parameter settings for the implementations in TriggerMenu/python/l1topomenu/TopoAlgoDef.py For example, for L1750 and L1751 in TopoAlgoDef.py do we need InputWidth1, InputWidth2 and MaxTob1,MaxTob2 parameters like we have for 0INVM10-0DR15-EM12abi-MU6ab on L1770? I tried using the parameters based on what is implemented in 6f606342 for ATR-19355 and in b312f102 for ATR-18815
I also see the use of "bitid" for example on L1643 of TopoAlgoDef.py, it wasn't clear if I should be adding this field for the new implementation.
It also wasn't clear when NumResultBits=1 should be used and when it should be set to: len(toponames), I used NumResultBits=1 based on implementations for similar triggers.
Thanks,
Aparajita