AthenaKernel: Fix deletion ordering problem with RecyclableDataObject.

Merged Scott Snyder requested to merge ssnyder/athena:delorder.AthenaKernel-20190307 into master

During finalization, it is possible that a component with a RecyclableDataQueue gets deleted while there are still associated data objects in the event store. This can then lead to a use-after-free error when the store is finalized. Be robust against this by allocating the underlying queue separately from RecyclableDataQueue and managing it using shared_ptr.

Should fix ATLASSIM-4044.

Also suppress warning from tbb header.

Merge request reports