Support TEfficiency in AthenaMonitoring

Allow users to use TEfficiency class in monitoring plots.

@ponyisi @tbold

Using defineHistogram('pT_passed,pT',type='TEfficiency',title='Test TEfficiency;x;Eff', path='AndInTheDarkness',xbins=100,xmin=0.0,xmax=50.0), and filling with some randomly-generated numbers, the following plot is produced in the output file.

This merge request affects 1 package:

• Control/AthenaMonitoring

Adding @ssnyder ,@rbianchi as watchers

added Core DQ master review-pending-level-1 labels

Hi, Very nice. It would be good to expand the test of histogram definition parsing & filling. The ones in the test/ directory. They are trivial but shield us from making some trivial mistake when making changes in this pkg.

Another thing that becomes obvious now is that the HistogramFillers hierarchy should be modified along the lines you were suggesting. Abstract base filler with fill() operation and templated implementations for various types of histograms. Is this going to be next move?

Tagging @fwinkl & @psarna

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21780-2019-03-09-14-08
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST 35154]

Jenkins please retry a build

Hi Tomasz - indeed I think our next step is to refactor with an abstract base class and templated concrete instances.

Best, Peter

Just a note to myself which shouldn't hold up this MR. We need to come up with a way to limit the histogram types for the online use-case. Maybe via the isOnline flag in python. The OH infrastructure at P1 only supports the very basic ROOT histogram types and I don't think TEfficiency is part of it.

This merge request affects 1 package:

• Control/AthenaMonitoring

Adding @ssnyder ,@rbianchi as watchers

Hi Frank - that's a good point - would you think we should do it already at the level of the Python?

TEfficiency is a useful enough type that possibly OH should be extended to deal with it...

The earlier we catch it the better I think. Python stage would be best.

About the online use for the TEfficiency ... in general online there is no good reference yet w.r.t. which it can be measured.

The TProfile is supported.

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21780-2019-03-11-23-05
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35235]

CI_TEST/CI_TEST_RUNNER: TEST FAILURE: G4ExHive returned code 99 This seems somewhat unrelated. Retry again?

No, this is known issue. Retry wont fix it.

added review-pending-level-2 label and removed review-pending-level-1 label

Test failure is known issue, from MR shifter point of vie code looks fine, so approving and let RC decide, if it should be merged now...

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

I think Tomasz' first comment still needs to be resolved, i.e. the extension of the unit tests for this new type.

added 1 commit

• c88cf7cd - Added example with units.

Compare with previous version

This merge request affects 1 package:

• Control/AthenaMonitoring

Adding @ssnyder ,@rbianchi as watchers