EmuStepProcessing test - newJO version (!21912) · Merge requests · atlas / athena · GitLab

Snippets Groups Projects

Merged Krzysztof Piotr Jamrog requested to merge kjamrog/athena:emutest into master 6 years ago

This MR contains second version of EmuStepProcessingTest created for testing newJO CF generation. Majority of EmuStepProcessingTest has been moved to the separate file so that it can be shared between both tests.

Tagging @tbold @fpastore

Activity

ATLAS Robot @atlasbot · 6 years ago

Developer
This merge request affects 2 packages:

Trigger/TrigValidation/TrigUpgradeTest

Trigger/TriggerCommon/TriggerMenuMT
ATLAS Robot added Trigger TriggerMenu master review-pending-level-1 labels 6 years ago

added Trigger TriggerMenu master review-pending-level-1 labels
Krzysztof Piotr Jamrog added 1 commit 6 years ago
added 1 commit

5241e918 - EmuStepProcessing test - newJO version

Compare with previous version
ATLAS Robot @atlasbot · 6 years ago

Developer
This merge request affects 2 packages:

Trigger/TrigValidation/TrigUpgradeTest

Trigger/TriggerCommon/TriggerMenuMT
ATLAS Robot @atlasbot · 6 years ago

Developer

CI Result FAILURE

Athena AthSimulation

externals

cmake

make

required tests

optional tests

Full details available at NICOS MR-21912-2019-03-14-19-16
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35424]
ATLAS Robot @atlasbot · 6 years ago

Developer

CI Result FAILURE

Athena AthSimulation

externals

cmake

make

required tests

optional tests

Full details available at NICOS MR-21912-2019-03-14-19-21
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35423]
Francesca Pastore @fpastore · 6 years ago

Developer

Hi, did you menage to run the full menu then?
Timo Dreyer @tidreyer · 6 years ago
There is an error in the unit tests:

post.sh> ERROR: RunMenuTest.log and ../share/RunMenuTest.ref differ

Do you need to update the reference maybe?

Cheers, Timo (L1)
Timo Dreyer added review-user-action-required label and removed review-pending-level-1 label 6 years ago

added review-user-action-required label and removed review-pending-level-1 label
Timo Dreyer @tidreyer · 6 years ago

Jenkins please retry a build
Timo Dreyer added review-pending-level-1 label and removed review-user-action-required label 6 years ago

added review-pending-level-1 label and removed review-user-action-required label
Timo Dreyer @tidreyer · 6 years ago

The failure might not be related to this MR, but Jenkins is having problems with time outs at the moment, so let's wait a bit...
K

Krzysztof Piotr Jamrog @kjamrog · 5 years ago

Author

Yes, those changes shouldn't influence this test in any way
Krzysztof Piotr Jamrog added 56 commits 5 years ago
added 56 commits

5241e918...5383c1a0 - 51 commits from branch atlas:master

99ad7f76 - EmuStepProcessing test - newJO version

a3b3b665 - Added combo steps handling in newJO

4e048940 - Remove redundant flags setting in EmuNewJOTest

cf9b142c - Add .dot generating in newJO CF creation

ec80b6e8 - Removed unnacessary imports

Compare with previous version
Toggle commit list
ATLAS Robot @atlasbot · 5 years ago

Developer
This merge request affects 2 packages:

Trigger/TrigValidation/TrigUpgradeTest

Trigger/TriggerCommon/TriggerMenuMT
ATLAS Robot @atlasbot · 5 years ago

Developer

CI Result FAILURE

Athena AthSimulation

externals

cmake

make

required tests

optional tests

Full details available at NICOS MR-21912-2019-03-17-02-38
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST 35554]
Tomasz Bold added NewConfig label 5 years ago

added NewConfig label
Timo Dreyer @tidreyer · 5 years ago

The test failures should be related to ATR-19546
Rafal Bielski @rbielski · 5 years ago

The MR causing the problem was reverted yesterday, feel free to rerun the CI if needed.
Tomasz Bold @tbold · 5 years ago

Developer

Yes, And we have a fix for the ref. differences merged in.
Timo Dreyer added review-pending-level-2 label and removed review-pending-level-1 label 5 years ago

added review-pending-level-2 label and removed review-pending-level-1 label
G

Sergio Grancagnolo @grancagn · 5 years ago

Developer

Let us then retry a build.
G

Sergio Grancagnolo @grancagn · 5 years ago

Developer

Jenkins please retry a build
ATLAS Robot @atlasbot · 5 years ago

Developer
This merge request affects 2 packages:

Trigger/TrigValidation/TrigUpgradeTest

Trigger/TriggerCommon/TriggerMenuMT
ATLAS Robot added review-pending-level-1 label and removed review-pending-level-2 label 5 years ago

added review-pending-level-1 label and removed review-pending-level-2 label
ATLAS Robot @atlasbot · 5 years ago

Developer

CI Result FAILURE

Athena AthSimulation

externals

cmake

make

required tests

optional tests

Full details available at NICOS MR-21912-2019-03-19-19-33
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35684]
K

Krzysztof Piotr Jamrog @kjamrog · 5 years ago

Author

Jenkins please retry a build
ATLAS Robot @atlasbot · 5 years ago

Developer
This merge request affects 2 packages:

Trigger/TrigValidation/TrigUpgradeTest

Trigger/TriggerCommon/TriggerMenuMT

Adding @rbielski as watcher
ATLAS Robot @atlasbot · 5 years ago

Developer

CI Result SUCCESS

Athena AthSimulation

externals

cmake

make

required tests

optional tests

Full details available at NICOS MR-21912-2019-03-21-14-27
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35779]
Ruchi Gupta added review-pending-level-2 label and removed review-pending-level-1 label 5 years ago

added review-pending-level-2 label and removed review-pending-level-1 label
Sergio Grancagnolo @grancagn started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jannik Geisen
Last reply by Sergio Grancagnolo 5 years ago

Sergio Grancagnolo @grancagn started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Jannik Geisen

Sergio Grancagnolo added label and removed label 5 years ago

added review-user-action-required label and removed review-pending-level-2 label

Tomasz Bold @tbold · 5 years ago

Developer

Good points. Can we none the less advance. This code is actively beeing worked on and the next MR is imminent.

Krzysztof Piotr Jamrog added 285 commits 5 years ago

added 285 commits

ec80b6e8...ec0b6df7 - 279 commits from branch atlas:master
eeab87d7 - EmuStepProcessing test - newJO version
c5713d7a - Added combo steps handling in newJO
bf567bd5 - Remove redundant flags setting in EmuNewJOTest
f974ee59 - Add .dot generating in newJO CF creation
68773da9 - Removed unnacessary imports
170b7547 - Replaced print with logger

Compare with previous version

Toggle commit list

ATLAS Robot @atlasbot · 5 years ago

Developer

This merge request affects 2 packages:

Trigger/TrigValidation/TrigUpgradeTest
Trigger/TriggerCommon/TriggerMenuMT

Adding @rbielski as watcher

ATLAS Robot added label and removed label 5 years ago

added review-pending-level-1 label and removed review-user-action-required label

Krzysztof Piotr Jamrog @kjamrog · 5 years ago

Author

Hi @grancagn, I've replaced prints with logger as suggested

ATLAS Robot @atlasbot · 5 years ago

Developer

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21912-2019-03-23-20-25
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35901]

Jannik Geisen resolved all discussions 5 years ago

resolved all discussions

Jannik Geisen @jgeisen · 5 years ago

Jenkins please retry a build

Jannik Geisen @jgeisen · 5 years ago

Hi all,

since all discussions are resolved after L2 review, I would go ahead and approve this MR if the CI build succeeds.

Best, Jannik (L1)

ATLAS Robot @atlasbot · 5 years ago

Developer

This merge request affects 2 packages:

Trigger/TrigValidation/TrigUpgradeTest
Trigger/TriggerCommon/TriggerMenuMT

Adding @rbielski as watcher

ATLAS Robot @atlasbot · 5 years ago

Developer

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21912-2019-03-25-18-54
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST 35930]

Tadej Novak @tadej · 5 years ago

Developer

Unrelated CI issues, approving.

Tadej (L1)

Tadej Novak added label and removed label 5 years ago

added review-approved label and removed review-pending-level-1 label

Edward Moyse merged 5 years ago

merged

Edward Moyse mentioned in commit 5 years ago

mentioned in commit 533b6d67

Stewart Martin-Haugh @smh started a thread on the diff 5 years ago

Trigger/TrigValidation/TrigUpgradeTest/test/test_emu_newjo.sh 0 → 100755

 #!/bin/sh
 # art-type: build
 # art-include: master/Athena
 rm -rf EmuNewJOTest.py bootstrap.pkl bootstrap.py
 # this is a hack to pre-confgure scheduler and other MT services,

Atlas Nightlybuild added label 5 years ago

added sweep:ignore label

Please register or sign in to reply