Cleanups of SCT_Monitoring package (ATLASDQ-679)

Cleanups of SCT_Monitoring package

• Remove malloc.
• Remove auto.
• Remove duplicated m_eventInfoKey.
• Remove unused m_stream.
• Fix m_eventInfoKey in SCT_MotherTriggerMonTool.
• Use static_cast.
• Use std::unique_ptr to remove delete if possible.
• Use ATH_CHECK instead of CHECK.
• Use range based for loop.
• Use indexFind instead of for loops.
• Use default destructor.
• Clean up codes (move initialization to DeclareProperty).
• Move cArrayUtilities.h to the iside of SCTHitsNoiseMonTool.cxx.
• Move default values from Python to C++.
• Replace clear1D using memset by {}.

https://its.cern.ch/jira/browse/ATLASDQ-679

This merge request affects 1 package:

• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

added InnerDetector master review-pending-level-1 labels

Jenkins please retry a build

There is a technical problem with unit tests in the previous build. Restarted.

This merge request affects 1 package:

• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21927-2019-03-15-06-38
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35456]

CI Failure seems to be the known G4ExHive problem, so not related to this MR.

added review-pending-level-2 label and removed review-pending-level-1 label

And changes looks fine to me, so approving.

Pavol [as ADCoS expert shifter]

added review-approved label and removed review-pending-level-2 label

marked as a Work In Progress

added 13 commits

• c3e992d9 - Use indexFind instead of for loops.
• 02f2abce - Replace auto
• 2c269d23 - Use static_cast
• b608b9e6 - Move cArrayUtilities.h to the iside of SCTHitsNoiseMonTool.cxx
• 736f45e1 - Cleanup of SCTTracksMonTool.cxx
• cad9bf60 - Use ATH_CHECK instead of CHECK
• 83abff9e - Use std::unique_ptr to remove delete.
• 98c80648 - Use operator bool
• e6d5b81d - Cleanup of SCTErrMonTool and SCTHitEffMonTool
• c2ce45df - Cleanup of SCTHitsNoiseMonTool, SCTLorentzMonTool, SCTMotherTrigMonTool
• a6497444 - Cleanup of SCTRatioNoiseMonTool
• d0928384 - Cleaup of SCTTracksMonTool
• 2bae3f00 - Use default destructor in SCTHitsNoiseMonTool

Compare with previous version

changed the description

unmarked as a Work In Progress

removed review-approved label

This merge request affects 1 package:

• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

added review-pending-level-1 label

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21927-2019-03-16-23-19
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST 35545]

added 1 commit

• da987b90 - Move default values from Python to C++.

Compare with previous version

changed the description

This merge request affects 2 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

marked as a Work In Progress

added 2 commits

• 31613a7d - Remove duplicated m_eventInfoKey
• 3071e6eb - Fix bugs

Compare with previous version

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21927-2019-03-17-05-52
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35563]

added 1 commit

• bf428675 - Fix a bug. Remove unused m_stream.

Compare with previous version

changed the description

added 1 commit

• eefcf5b1 - Replace clear1D using memset by {}.

Compare with previous version

changed the description

unmarked as a Work In Progress

This merge request affects 2 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

changed the description

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21927-2019-03-17-10-22
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35564]

added 23 commits

• eefcf5b1...43dab63b - 22 commits from branch atlas:master
• 98fc9e39 - Merge remote-tracking branch 'upstream/master' into master-SCT_Monitoring-v3-2

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21927-2019-03-17-17-14
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35567]

CI failures should be due to https://its.cern.ch/jira/browse/ATR-19546

Jenkins please retry a build

added 11 commits

• 98fc9e39...a8ac2b13 - 10 commits from branch atlas:master
• 408ce8fa - Merge remote-tracking branch 'upstream/master' into master-SCT_Monitoring-v3-2

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21927-2019-03-18-23-44
Athena: number of compilation errors 1, warnings 1
AthSimulation: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST 35600]

Jenkins please retry a build

This merge request affects 2 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21927-2019-03-19-02-44
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35625]

Jenkins please retry a build

This merge request affects 2 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/SCT_Monitoring

Adding @oda as watcher

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21927-2019-03-19-09-45
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35648]

added review-pending-level-2 label

removed review-pending-level-1 label