Skip to content
Snippets Groups Projects

Protection against calling G4ThreadInitTool::terminateThread without having called initThread

All threads resolved!

Based on the discussion in ATLASSIM-4062, it seems that with the new version of TBB introduced in LCG_95 (see !21493 (merged)) can sometimes try to call G4ThreadInitTool::terminateThread without having first called G4ThreadInitTool::initThread. This causes the G4ExHive-test CI test to fail at random. Adding some protection to G4ThreadInitTool::terminateThread to prevent crashes in this case while the experts follow up with the TBB experts.

Edited by John Derek Chapman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 51c78246 - Protection against calling G4ThreadInitTool::terminateThread without having called initThread

    Compare with previous version

  • John Derek Chapman resolved all discussions

    resolved all discussions

  • Jenkins please retry a build

  • Jenkins please retry a build

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Simulation/G4Atlas/G4AtlasTools

    Adding @jchapman ,@vpascuzz as watchers

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-21932-2019-03-16-02-14
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 35531]

  • Looks fine, needed quickly, approving.

    Pavol [as L2 MR shifter]

  • mentioned in commit ea1b2c49

  • Sergio Grancagnolo mentioned in merge request !21787 (merged)

    mentioned in merge request !21787 (merged)

  • Please register or sign in to reply
    Loading