CaloIdentifier: Fix cppcheck warnings.

Fix cppcheck warnings, including:

• Use preincrement in iteration;
• Initialize members in an initializer list;
• Pass std::string by reference;
• Format string type match.