Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 169
    • Merge requests 169
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !22101

Follow up !21787 - ATLAS naming convention updates in TrigEgammaIsolationSelectorTool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Tim Martin requested to merge tamartin/athena:fixCompilerWarnings into master Mar 22, 2019
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx: In member function 'virtual bool Trig::TrigEgammaIsolationSelectorTool::emulation(const xAOD::IParticle*, bool&, const Trig::Info&)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:152:52: warning: ATLAS coding standards require that variable name '_m_PtCone' not start with '_'.
   std::vector<float>  EtCone, PtCone_xAOD, PtCone, _m_PtCone, _m_PtVarCone, PtCone_recalculated; //, PtCone_recalculated_fixed;
                                                    ^~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:152:52: note: See <https://twiki.cern.ch/twiki/bin/view/AtlasComputing/CheckerGccPlugins#naming_plugin>.
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:152:63: warning: ATLAS coding standards require that variable name '_m_PtVarCone' not start with '_'.
   std::vector<float>  EtCone, PtCone_xAOD, PtCone, _m_PtCone, _m_PtVarCone, PtCone_recalculated; //, PtCone_recalculated_fixed;
                                                               ^~~~~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:152:63: note: See <https://twiki.cern.ch/twiki/bin/view/AtlasComputing/CheckerGccPlugins#naming_plugin>.
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:208:15: warning: ATLAS coding standards require that variable name 'm_trk_container' not start with 'm_'.
   std::string m_trk_container =  el->trackParticleLink().dataID();
               ^~~~~~~~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:208:15: note: See <https://twiki.cern.ch/twiki/bin/view/AtlasComputing/CheckerGccPlugins#naming_plugin>.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fixCompilerWarnings