Skip to content

Follow up !21787 - ATLAS naming convention updates in TrigEgammaIsolationSelectorTool

Tim Martin requested to merge tamartin/athena:fixCompilerWarnings into master
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx: In member function 'virtual bool Trig::TrigEgammaIsolationSelectorTool::emulation(const xAOD::IParticle*, bool&, const Trig::Info&)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:152:52: warning: ATLAS coding standards require that variable name '_m_PtCone' not start with '_'.
   std::vector<float>  EtCone, PtCone_xAOD, PtCone, _m_PtCone, _m_PtVarCone, PtCone_recalculated; //, PtCone_recalculated_fixed;
                                                    ^~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:152:52: note: See <https://twiki.cern.ch/twiki/bin/view/AtlasComputing/CheckerGccPlugins#naming_plugin>.
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:152:63: warning: ATLAS coding standards require that variable name '_m_PtVarCone' not start with '_'.
   std::vector<float>  EtCone, PtCone_xAOD, PtCone, _m_PtCone, _m_PtVarCone, PtCone_recalculated; //, PtCone_recalculated_fixed;
                                                               ^~~~~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:152:63: note: See <https://twiki.cern.ch/twiki/bin/view/AtlasComputing/CheckerGccPlugins#naming_plugin>.
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:208:15: warning: ATLAS coding standards require that variable name 'm_trk_container' not start with 'm_'.
   std::string m_trk_container =  el->trackParticleLink().dataID();
               ^~~~~~~~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/master/Trigger/TrigAnalysis/TrigEgammaEmulationTool/Root/TrigEgammaIsolationSelectorTool.cxx:208:15: note: See <https://twiki.cern.ch/twiki/bin/view/AtlasComputing/CheckerGccPlugins#naming_plugin>.

Merge request reports

Loading