Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 166
    • Merge requests 166
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !22147
The source project of this merge request has been removed.

Fix l1topo items crash

Merged Nicola Orlando requested to merge (removed):l1topo_sim_fix_mixed_EM_items_2 into 21.3 Mar 26, 2019
  • Overview 8
  • Pipelines 0
  • Changes 1

This MR address a common crash happening for L1Topo based items using combined objects with different conventions for the phi angle definition (EM/mu, jets/mu, ..). The fix is a simple phi shift on the cases where the phi is defined between [0,2pi] which moved the range to [-pi,pi]. This fix activates only for cases with delta-phi > 64, thus should not affect pre-existing items with unmixed types of input collections.

Addressing several crashes in the menu as reported for example here:

  • https://its.cern.ch/jira/browse/ATR-18815
  • https://its.cern.ch/jira/browse/ATR-18824
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: l1topo_sim_fix_mixed_EM_items_2