ATH_CHECK: Do not print FATAL message for RECOVERABLE
This MR consists of several parts, which could have been done separately, but since each of them has the risk of requiring updates to various reference files, it's better to have them all merged in one go:
- Extend the CHECK unit test to include a custom
StatusCode
(Timeout). Include the category name in theAthStatusCode::message()
. -
CHECK
macro: Instead of printing theStatusCode
numeric value (e.g.0
) print the message (e.g.FAILURE
). This is especially useful for customStatusCode
categories. - The
CHECK
macros would print anERROR
message in case theStatusCode
under check isRECOVERABLE
, otherwise aFATAL
message. Change this to always print anERROR
message.FATAL
messages should be left to the framework when deciding to abort the job. This point was discussed (and agreed) in today's reco meeting (https://indico.cern.ch/event/808941/). Our https://twiki.cern.ch/twiki/bin/view/AtlasComputing/ReportingErrors policy will be updated accordingly. - Added a unit test for all macros to ensure the "checking" logic is correct.
Edited by Frank Winklmeier