ATH_CHECK: Do not print FATAL message for RECOVERABLE
This MR consists of several parts, which could have been done separately, but since each of them has the risk of requiring updates to various reference files, it's better to have them all merged in one go:
- Extend the CHECK unit test to include a custom
StatusCode(Timeout). Include the category name in the
CHECKmacro: Instead of printing the
StatusCodenumeric value (e.g.
0) print the message (e.g.
FAILURE). This is especially useful for custom
CHECKmacros would print an
ERRORmessage in case the
StatusCodeunder check is
RECOVERABLE, otherwise a
FATALmessage. Change this to always print an
FATALmessages should be left to the framework when deciding to abort the job. This point was discussed (and agreed) in today's reco meeting (https://indico.cern.ch/event/808941/). Our https://twiki.cern.ch/twiki/bin/view/AtlasComputing/ReportingErrors policy will be updated accordingly.
- Added a unit test for all macros to ensure the "checking" logic is correct.