Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 181
    • Merge requests 181
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !22254

ComponentAccumulator: Reorganize deduplication

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Walter Lampl requested to merge wlampl/athena:CA.InvertDeDuplication into master Mar 29, 2019
  • Overview 19
  • Commits 24
  • Pipelines 4
  • Changes 8

Changes to the deduplication of Components in the ComponentAccumulator, as discussed in the job config meeting of March 28th

  • Move de-duplication to a separate python file (no dependency on the rest of ComponentAccumulator)
  • Make sure that after calling acc.addService(svc) svc and the service inside the acc point to the same instance. To achieve this, the deduplicaton updates the properties of the component given as parameter and then assigns this component to the list of components in the accumulator, effectively overwriting the previous instance. That applies to all add-methods as well as to the merge method of the ComponentAccumulator.
  • Make sure the order of elements in list-properties (and ToolHandleArrays) is maintained when de-duplicating

Tagging @tbold and @kjamrog

Edited Mar 29, 2019 by Walter Lampl
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: CA.InvertDeDuplication