Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !22401

Migrated several JobTransforms related modules to Python3 using futurize

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Pascal Rene Baehr requested to merge pbahr/athena:master-pyjobtransforms-2to3 into master Apr 04, 2019
  • Overview 32
  • Commits 11
  • Pipelines 9
  • Changes 137

Short term the code should work in both versions of Python, the futurize tool was used for basic migration. This adds some overhead with additional libraries which should be removed once a full transition to Python 3 is done. Additionally various error prone cases where the "is" operator has been used were changed and now use the "==" operator instead.

Most of the modules were properly tested with the existing unit tests from PyJobTransforms. Since the scope of the changes is quite big a few modules might have been missed there. Changes were mostly made with basic the basic futurize migration strategy, autopep8 for code style, followed by adding manual fixes.

I consider the work for those modules done, additional test scenarios could be discussed before fully merging the changes into master.

EDIT: Proper testing would involve getting everything to run solely on Python 3, which I couldn't make work yet on lxplus.

Edited Apr 11, 2019 by Pascal Rene Baehr
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-pyjobtransforms-2to3