Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 193
    • Merge requests 193
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !22418

Closed
Created Apr 04, 2019 by Rupert Tombs@rtombsDeveloper
  • Report abuse
Report abuse

WIP: FreeAccumulator for unit tests

  • Overview 2
  • Commits 1
  • Changes 2

Proposition for a way to clearly allow ComponentAccumulators to be deleted without error.

Create TestUtility.py defining FreeAccumulator. Use FreeAccumulator for SCT_Digitization config test.

This is intended to remove the need for acc.popPrivateTools(); acc.wasMerged() lines in unit tests which create but do not need to merge ComponentAccumulators.

Minor cleanup to SCT_DigitizationConfigNew_test.py.

Q:

Does this give enough clarity?

Is there a better location, such as inside ComponentAccumulator class?

Should acc be returned?

Edited Apr 04, 2019 by Rupert Tombs
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: FreeAccumulator