Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Jira
    • Jira
  • Merge requests 138
    • Merge requests 138
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !22418

WIP: FreeAccumulator for unit tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Rupert Tombs requested to merge rtombs/athena:FreeAccumulator into master Apr 04, 2019
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

Proposition for a way to clearly allow ComponentAccumulators to be deleted without error.

Create TestUtility.py defining FreeAccumulator. Use FreeAccumulator for SCT_Digitization config test.

This is intended to remove the need for acc.popPrivateTools(); acc.wasMerged() lines in unit tests which create but do not need to merge ComponentAccumulators.

Minor cleanup to SCT_DigitizationConfigNew_test.py.

Q:

Does this give enough clarity?

Is there a better location, such as inside ComponentAccumulator class?

Should acc be returned?

Edited Apr 04, 2019 by Rupert Tombs
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: FreeAccumulator