Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 156
    • Merge requests 156
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !22582

Calo noise alg clients1

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Walter Lampl requested to merge wlampl/athena:CaloNoiseAlgClients1 into master Apr 11, 2019
  • Overview 8
  • Commits 19
  • Pipelines 3
  • Changes 12

This MR migrates the CaloTopoClusterMaker to the new CaloNoise conditions object, removing the dependency on the thread-unsafe CaloNoiseTool.

On top of this, a number of obsolete features of the TopoClusterMaker are removed. This was discussed on the calo-perf mailing list.

While testing this, I found that the implementation of the CaloNoise::getEffectiveSigma (that is used to account for the double-gaussian noise observed in the TileCal during some periods) was wrong. This MR fixes also this problem. I verified that the resulting CaloCalTopoClusters container remains identical.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: CaloNoiseAlgClients1