Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 148
    • Merge requests 148
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !22628

More clients of CaloNoiseAlg

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Walter Lampl requested to merge wlampl/athena:CaloNoiseAlgClients2a into master Apr 12, 2019
  • Overview 14
  • Commits 30
  • Pipelines 2
  • Changes 18

This one contains (and superseeds) !22582 (closed).

It contains: Migration of the CaloTopoClusterMaker, CaloClusterMomentsMaker and CaloTopoTowerAlg to the new CaloNoise conditions object, removing the dependency on the thread-unsafe CaloNoiseTool.

On top of this, a number of obsolete features of the TopoClusterMaker are removed. This was discussed on the calo-perf mailing list.

While testing this, I found that the implementation of the CaloNoise::getEffectiveSigma (that is used to account for the double-gaussian noise observed in the TileCal during some periods) was wrong. This MR fixes also this problem. I verified that the resulting CaloCalTopoClusters container remains identical.

It contains also fixes for the CI failures observed in !22582 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: CaloNoiseAlgClients2a