TrigT2Calo: Cleanup and remove obsolete code

This is a major cleanup of the MT-related code in the TrigT2CaloEgamma package. Many files were touched but mostly code was removed and modernized:

• Delete T2CaloEgammaFastAlgo, which was an early prototype and replaced by T2CaloEgammaReFastAlgo
• Delete some other obsolete job option files
• Python cleanup and add flake8 unit test
• Move private headers to src directory and only build a component library
• Enable static thread-safety checker

Major cleanup for the MT-base classIReAlgToolCalo:

• Remove all obsolete code
• Remove non-MT version of execute method
• Pass EventContext by reference instead of pointer in execute
• Remove error bits (not thread-safe)
• Unify code style using clang-format
• Update clients to changes and do some further cleanup.

marked as a Work In Progress

added 1 commit

• dbfdd779 - IReAlgToolCalo: Major cleanup

Compare with previous version

added 73 commits

• dbfdd779...82e1b07b - 69 commits from branch atlas:master
• b02876b9 - Delete T2CaloEgammaFastAlgo
• 2289885a - TrigT2CaloEgamma: Move headers to src directory
• 27ff0830 - TrigT2CaloEgamma: Python cleanup and add flake8 unit test
• c300e8b5 - IReAlgToolCalo: Major cleanup

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: T2calo cleanup to TrigT2Calo: Cleanup and remove obsolete code

changed the description

added full-unit-tests label

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigAlgorithms/TrigT2CaloEgamma

Adding @damazio as watcher

added Egamma Trigger master review-pending-level-1 labels

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigAlgorithms/TrigT2CaloEgamma

Adding @damazio as watcher

Great to see this. However the error handling was removed. What is the plan for that one? Wait for the boost outcome? Pack bits in SC?

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22806-2019-04-19-10-07
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 37372]

removed full-unit-tests label

According to Denis the error handling isn't needed. But we can discussed this separately.

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigAlgorithms/TrigT2CaloEgamma

Adding @damazio as watcher

Oh, if not needed anymore then great. Maybe one can monitor their occurrence​. Anyways, this is a separate topic.

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22806-2019-04-20-17-55
Athena: number of compilation errors 0, warnings 4
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 37399]

Looks OK, approving.

Tadej (L2)

added review-approved label and removed review-pending-level-1 label