Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !22911

Add empty and common steps in HLT CF menu

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Francesca Pastore requested to merge fpastore/athena:mergeMETjet into master Apr 24, 2019
  • Overview 87
  • Commits 26
  • Pipelines 8
  • Changes 22

HLTAllSteps.dot.pdf

Main changes in the CF builder to manage chains that share only parts of sequences. If two chains have a common step, but rest is different, the CF sequence is duplicated because one needs a new Filter+new Hypo (duplicated as well). This makes the graph more complicated to debug. See attached diagram.

Some changes in the CF builder to include the empty steps. Empty steps are managed as steps with one Filter Alg only, so successive step receives the output of the FilterAlg, instead of the Hypoalg. Some changes are needed in the Dot functions, to envisage such cases. The emu_step test has been made more modular, to allow preparing more complex and large menus in the unit tests. Added more use-cases in this test. Covering use cases in ATR-19600. Many ref files are updated, need to ask the experts if reasonable results are reached with these changes.

Edited Apr 30, 2019 by Francesca Pastore
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mergeMETjet