Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 155
    • Merge requests 155
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !22912

jFEX jet algorithms and MET container name fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ben Carlson requested to merge BugFixes into 21.3 Apr 24, 2019
  • Overview 14
  • Commits 2
  • Pipelines 2
  • Changes 4

This algorithm fixes a bug in the jFEX jet algorithm. The current local maximum finder assumes you have signed deltaPhi values, which were not returned from the helper function. That was fixed, and the absolute value explicitly added where needed.

During the debugging, it was also realized that because the tile energy is taken from the Run 2 container with a noise cut already applied, the way we derive noise thresholds is not really sensible. Given that during the startup, we have to share noise cuts with Run 2 anyway, it probably makes sense to not apply tile noise cuts. Those were removed for the jet algorithm anyway.

In addition, there is a minor fix to the MET Aux container name.

https://indico.cern.ch/event/815351/contributions/3402864/attachments/1833198/3005892/Carlson_Debugging_jFEXJets.pdf

Edited Apr 26, 2019 by Ben Carlson
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: BugFixes