Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 173
    • Merge requests 173
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !23091

Merged
Created May 01, 2019 by Scott Snyder@ssnyderDeveloper

CaloDetDescr+TrigUpgradeTest: Preparing to make CaloDD immutable.

  • Overview 3
  • Commits 2
  • Pipelines 1
  • Changes 6

Previously, we were creating the CaloDD via a converter, then applying alignments via conditions callbacks. This this meant that the CaloDD will be different depending on whether we're looking before or after alignments have been applied. This can then lead to problems if the CaloDD is retrieved too early. The const_cast'ing needed is also problematic for MT.

Instead of building CaloDD via a converter, we want to move to creating it explicitly as part of doing alignments.

However, this means that in general, we shouldn't be trying to retrieve CaloDetDescrManager during initialize(). Rework to avoid this. Change CaloDepthTool to retrieve CaloDD lazily, using CachedPointer.

CaloDetDescrManager initialization ordering changes in CaloDepthTool can change output. Update TrigUpgradeTest reference files correspondingly.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: calodd-depth.CaloDetDescr-20190501