Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 184
    • Merge requests 184
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !23105

Merged
Created May 01, 2019 by Nicolas Koehler@nkoehlerContributor

add nullptr check to createTable() method as done for CSCs, MDTs and TGCs

  • Overview 7
  • Commits 1
  • Pipelines 1
  • Changes 2

Hi,

this MR adds a nullptr check to the createTable() method of the MM_RegionSelectorTable.cxx and sTGC_RegionSelectorTable.cxx as it is also done for the CSCs, MDTs and TGCs already. The nullptr check can become important in case an identifier dictionnary in the IdDictParser package contains identifiers to detector elements which are not part of a layout. Without the nullptr check, the code would cause a segmentation violation.

Best, Nico

Adding @morgens and @markowen for the trigger Adding @rosati, @wleight and @cchau for MuonSW

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: muRegSel