Skip to content

RpcDataPreparator: Code cleanup and optimization (ATR-19743)

Frank Winklmeier requested to merge fwinkl/athena:trigl2muonsa_cleanup1 into master
  • Remove unnecessary InterfaceID declarations
  • Move properties to header file
  • Remove unnecessary includes
  • Calling base class initialize/finalize is not necessary
  • Remove event/detector store handles and use them from base class
  • Use range-based for loops
  • Use vector::reserve where possible
  • Do not import namespaces (using namespace xyz)
  • Optimize eta/phi calculation:
    • Use r^2 to avoid redundant sqr(sqrt(...)) calculation
    • Use helper to wrap phi
    • Use M_PI from cmath instead of CLHEP

cc @shhayash @yoyamagu @markowen

Edited by Frank Winklmeier

Merge request reports