Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 187
    • Merge requests 187
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !23186

Merged
Created May 04, 2019 by Susumu Oda@odaContributor

Code cleanup of SiSpacePointsSeedTool_xk package (ATLASRECTS-3037)

  • Overview 22
  • Commits 15
  • Pipelines 4
  • Changes 22

Code cleanup of SiSpacePointsSeedTool_xk package

  • Use ATH_MSG macros.
  • Use static_cast.
  • Use range based for loop.
  • Add space after if, for and while.
  • Change if-else style.
  • Change indentation.
  • Remove space after ;
  • Add virtual to inherit methods.
  • Fix array size 593 -> 583.
  • Move long inline methods to the cxx files.
  • Change protected to private.
  • Replace std::endl by endmsg.
  • Use constexpr.
  • Use forward declaration.

RunTier0Tests.py was fine. RunTier0Tests.log

Edited May 17, 2019 by Susumu Oda
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-SiSpacePointsSeedMaker_ATLxk-v2