Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 164
    • Merge requests 164
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !23274

Merged
Created May 08, 2019 by Tadej Novak@tadejDeveloper

Add SysDecorationHandle to event and JVT algs

  • Overview 8
  • Commits 2
  • Pipelines 3
  • Changes 10

This is a follow-up of !23179 (merged) adding SysDecorationHandle support to the AsgEventScaleFactorAlg and JvtEfficiencyAlg.

The changes here are less trivial so some comments are needed (mainly for @krumnack):

  • AsgEventScaleFactorAlg has two handles, one for input and one for output. They require different systematics to work as expected.
  • AsgEventScaleFactorAlg drops the need to make a copy of the EventInfo, that's why I added PRW to tests as we need a copy made before so we can decorate it
  • Some output in the tests is commented out until we resolve the issues with writing the output (will open a WIP MR tomorrow).
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: analysis/jvteff